New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CARBONDATA-2393]TaskNo is not working for SDK #2224
Conversation
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4513/ |
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4205/ |
}); | ||
Assert.assertNotNull(dataFiles); | ||
Assert.assertTrue(dataFiles.length > 0); | ||
String[] splitedcarbonFileName = getSplitedcarbonFileName(dataFiles[0]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use CarbonTablePath.getTaskNo method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
call this in finally block FileUtils.deleteDirectory(new File(path));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.Fixed
59d0347
to
2ac34ef
Compare
retest please |
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4516/ |
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4208/ |
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5375/ |
retest this please |
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5529/ |
6ab7413
to
2af5e91
Compare
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5532/ |
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4367/ |
retest this please |
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4632/ |
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5536/ |
2af5e91
to
e55e6bf
Compare
retest this please |
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4373/ |
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5539/ |
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4635/ |
LGTM |
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4376/ |
Issue:- Task No is not getting reflected in the Carbon Data file and in index file . Cause :- Task No is getting overwritten in CarbonTableOutputformate even CarbonModel have taskNo. Solution :- if CarbomModel has taskNo then no need to overwrite . This closes apache#2224
Issue:- Task No is not getting reflected in the Carbon Data file and in index file .
Cause :- Task No is getting overwritten in CarbonTableOutputformate even CarbonModel have taskNo.
Solution :- if CarbomModel has taskNo then no need to overwrite .
Any interfaces changed?
NO
Any backward compatibility impacted?
NO
Document update required?
NO
Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
added TestCase
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA