Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-2393]TaskNo is not working for SDK #2224

Closed
wants to merge 1 commit into from

Conversation

BJangir
Copy link
Contributor

@BJangir BJangir commented Apr 24, 2018

Issue:- Task No is not getting reflected in the Carbon Data file and in index file .

Cause :- Task No is getting overwritten in CarbonTableOutputformate even CarbonModel have taskNo.

Solution :- if CarbomModel has taskNo then no need to overwrite .

  • Any interfaces changed?
    NO

  • Any backward compatibility impacted?
    NO

  • Document update required?
    NO

  • Testing done
    Please provide details on
    - Whether new unit test cases have been added or why no new tests are required?
    - How it is tested? Please attach test report.
    added TestCase
    - Is it a performance related change? Please attach the performance test report.
    - Any additional information to help reviewers in testing this change.

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4513/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4205/

});
Assert.assertNotNull(dataFiles);
Assert.assertTrue(dataFiles.length > 0);
String[] splitedcarbonFileName = getSplitedcarbonFileName(dataFiles[0]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use CarbonTablePath.getTaskNo method

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call this in finally block FileUtils.deleteDirectory(new File(path));

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.Fixed

@BJangir BJangir force-pushed the CARBONDATA-2393 branch 2 times, most recently from 59d0347 to 2ac34ef Compare April 24, 2018 17:27
@BJangir
Copy link
Contributor Author

BJangir commented Apr 24, 2018

retest please

@ravipesala
Copy link
Contributor

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4516/

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4208/

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5375/

@ajantha-bhat
Copy link
Member

retest this please

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5529/

@BJangir BJangir force-pushed the CARBONDATA-2393 branch 2 times, most recently from 6ab7413 to 2af5e91 Compare April 30, 2018 09:07
@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5532/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4367/

@BJangir
Copy link
Contributor Author

BJangir commented Apr 30, 2018

retest this please

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4632/

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5536/

@BJangir
Copy link
Contributor Author

BJangir commented Apr 30, 2018

retest this please

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4373/

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5539/

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4635/

@kumarvishal09
Copy link
Contributor

LGTM

@asfgit asfgit closed this in 1613471 Apr 30, 2018
@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4376/

anubhav100 pushed a commit to anubhav100/incubator-carbondata that referenced this pull request Jun 22, 2018
Issue:- Task No is not getting reflected in the Carbon Data file and in index file .
Cause :- Task No is getting overwritten in CarbonTableOutputformate even CarbonModel have taskNo.
Solution :- if CarbomModel has taskNo then no need to overwrite .

This closes apache#2224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants