Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-2610] Fix for datamap creation failed on table having loaded data with null value on string datatype #2376

Closed
wants to merge 1 commit into from

Conversation

jatin9896
Copy link
Contributor

Problem: Datamap creation having null values already loaded in string datatype of table fails.
Solution: Check for null before converting data to the string.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

  • Any interfaces changed? No

  • Any backward compatibility impacted? No

  • Document update required? No

  • Testing done
    Please provide details on
    - Whether new unit test cases have been added or why no new tests are required? Yes
    - How it is tested? Please attach test report.
    - Is it a performance related change? Please attach the performance test report.
    - Any additional information to help reviewers in testing this change.

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA

@jatin9896 jatin9896 changed the title [CARBONDATA-2610] Fix for Null values in datamap [CARBONDATA-2610] Fix for datamap creation failed on table having loaded data with null value on string datatype Jun 14, 2018
@CarbonDataQA
Copy link

Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5184/

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5294/

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6346/

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5296/

@jackylk
Copy link
Contributor

jackylk commented Jun 18, 2018

LGTM

@asfgit asfgit closed this in e7fed36 Jun 18, 2018
sv71294 pushed a commit to sv71294/carbondata that referenced this pull request Jun 22, 2018
…ded data with null value on string datatype

Problem: Datamap creation having null values already loaded in string datatype of table fails.
Solution: Check for null before converting data to the string.

This closes apache#2376
anubhav100 pushed a commit to anubhav100/incubator-carbondata that referenced this pull request Jun 22, 2018
…ded data with null value on string datatype

Problem: Datamap creation having null values already loaded in string datatype of table fails.
Solution: Check for null before converting data to the string.

This closes apache#2376
asfgit pushed a commit that referenced this pull request Jul 30, 2018
…ded data with null value on string datatype

Problem: Datamap creation having null values already loaded in string datatype of table fails.
Solution: Check for null before converting data to the string.

This closes #2376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants