Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-2611] Added Test Cases for Local Dictionary Support for Create Table comand #2377

Closed

Conversation

praveenmeenakshi56
Copy link
Contributor

@praveenmeenakshi56 praveenmeenakshi56 commented Jun 14, 2018

What changes were proposed in this pull request?

  1. In this PR, UTs and SDV test cases are added for local dictionary support for create table command and describe formatted command.

  2. changed the error message for validation of local dictionary table properties and fixed column name display without extra space in describe formatted command

How was this patch tested?

UTs are added and SDV test cases are tested in cluster.

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6345/

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5183/

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5295/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5187/

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6350/

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5300/

@praveenmeenakshi56 praveenmeenakshi56 force-pushed the local_dict branch 2 times, most recently from 9adc0a9 to 879d00a Compare June 19, 2018 09:34
@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6374/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5212/

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5322/

@praveenmeenakshi56 praveenmeenakshi56 force-pushed the local_dict branch 2 times, most recently from 2bf4e68 to 616ecce Compare June 19, 2018 15:42
@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6386/

@praveenmeenakshi56
Copy link
Contributor Author

retest this please

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6389/

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5223/

@praveenmeenakshi56
Copy link
Contributor Author

retest this please

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6392/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5226/

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5333/

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5334/

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5336/

@kumarvishal09
Copy link
Contributor

LGTM

1 similar comment
@akashrn5
Copy link
Contributor

LGTM

bhavya411 referenced this pull request in NashTech-Labs/incubator-carbondata Aug 3, 2018
…reate Table comand

What changes were proposed in this pull request?
In this PR, UTs and SDV test cases are added for local dictionary support for create table command and describe formatted command.

changed the error message for validation of local dictionary table properties and
fixed column name display without extra space in describe formatted command

This closes#2377
kunal642 referenced this pull request in kunal642/carbondata Aug 28, 2018
…reate Table comand

What changes were proposed in this pull request?
In this PR, UTs and SDV test cases are added for local dictionary support for create table command and describe formatted command.

changed the error message for validation of local dictionary table properties and
fixed column name display without extra space in describe formatted command

This closes#2377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants