[CARBONDATA-2642] Added configurable Lock path property #2406

kunal642 · 2018-06-25T05:29:54Z

A new property is being exposed which will allow the user to configure the lock path.
Refactored code to create a separate implementation for S3CarbonFile.

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

Any interfaces changed?
Any backward compatibility impacted?
Document update required?
Updated
Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

CarbonDataQA · 2018-06-25T05:38:03Z

Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5345/

CarbonDataQA · 2018-06-25T05:41:29Z

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6513/

ravipesala · 2018-06-25T06:52:39Z

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5430/

CarbonDataQA · 2018-06-25T07:27:48Z

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6515/

CarbonDataQA · 2018-06-25T07:46:15Z

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5347/

ravipesala · 2018-06-25T08:53:00Z

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5432/

CarbonDataQA · 2018-06-25T12:02:06Z

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6524/

CarbonDataQA · 2018-06-25T12:51:22Z

Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5356/

CarbonDataQA · 2018-06-25T14:12:29Z

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6529/

ravipesala · 2018-06-25T14:22:07Z

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5437/

CarbonDataQA · 2018-06-25T15:48:32Z

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6533/

CarbonDataQA · 2018-06-25T16:59:01Z

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5363/

CarbonDataQA · 2018-06-26T09:56:34Z

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6551/

CarbonDataQA · 2018-06-26T09:57:48Z

Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5380/

ravipesala · 2018-06-26T14:38:16Z

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5455/

CarbonDataQA · 2018-06-26T19:36:57Z

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6564/

CarbonDataQA · 2018-06-26T20:04:44Z

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5393/

ravipesala · 2018-06-27T04:52:47Z

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5470/

kunal642 · 2018-06-27T12:54:04Z

retest this please

CarbonDataQA · 2018-06-27T17:13:36Z

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6595/

CarbonDataQA · 2018-06-27T20:13:35Z

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5418/

CarbonDataQA · 2018-06-28T03:39:03Z

Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5428/

kunal642 · 2018-06-28T04:13:48Z

@gvramana @ravipesala Please review

gvramana · 2018-07-05T06:43:57Z

processing/src/test/java/org/apache/carbondata/lcm/locks/LocalFileLockTest.java

+    f.set(secretClass, rootPath + "/target/");
+    AbsoluteTableIdentifier absoluteTableIdentifier = AbsoluteTableIdentifier
+        .from(CarbonProperties.getInstance().getProperty("carbon.storelocation"), "databaseName",
+            "tableName", "1");


reset the lockpath in testcase finally clause

CarbonDataQA · 2018-07-05T09:43:36Z

Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5612/

CarbonDataQA · 2018-07-05T09:44:44Z

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6805/

brijoobopanna · 2018-07-05T10:28:11Z

retest this please

CarbonDataQA · 2018-07-05T10:33:25Z

Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5617/

CarbonDataQA · 2018-07-05T10:54:43Z

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6817/

CarbonDataQA · 2018-07-05T11:09:03Z

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6821/

CarbonDataQA · 2018-07-05T11:26:17Z

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6826/

kunal642 · 2018-07-05T11:30:31Z

retest this please

CarbonDataQA · 2018-07-05T11:38:24Z

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6829/

kunal642 · 2018-07-05T11:40:01Z

retest this please

CarbonDataQA · 2018-07-05T11:50:22Z

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6831/

kunal642 · 2018-07-05T13:25:10Z

retest this please

ravipesala · 2018-07-05T14:03:01Z

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5632/

CarbonDataQA · 2018-07-05T14:59:00Z

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5626/

CarbonDataQA · 2018-07-05T15:14:51Z

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6840/

brijoobopanna · 2018-07-05T16:33:39Z

retest sdv please

ravipesala · 2018-07-05T18:15:56Z

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5644/

CarbonDataQA · 2018-07-05T21:03:03Z

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5635/

CarbonDataQA · 2018-07-06T08:49:46Z

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6879/

ravipesala · 2018-07-06T10:21:53Z

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5658/

gvramana · 2018-07-06T12:02:56Z

LGTM

CarbonDataQA · 2018-07-07T03:09:26Z

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5682/

kunal642 force-pushed the S3CarbonFile branch from 705824b to 4f36bd9 Compare June 25, 2018 05:56

kunal642 force-pushed the S3CarbonFile branch from 4f36bd9 to 51754ca Compare June 25, 2018 08:22

kunal642 force-pushed the S3CarbonFile branch from 51754ca to c2b5231 Compare June 25, 2018 12:55

kunal642 force-pushed the S3CarbonFile branch from c2b5231 to 0665c05 Compare June 25, 2018 14:49

kunal642 force-pushed the S3CarbonFile branch from 0665c05 to 118a88a Compare June 26, 2018 09:00

kunal642 force-pushed the S3CarbonFile branch from 118a88a to a3d8e86 Compare June 26, 2018 12:35

kunal642 changed the title ~~[CARBONDATA-2640][CARBONDATA-2642] Added configurable Lock path property~~ [CARBONDATA-2642] Added configurable Lock path property Jun 27, 2018

gvramana reviewed Jul 5, 2018

View reviewed changes

kunal642 force-pushed the S3CarbonFile branch from 2b417db to df1a25c Compare July 5, 2018 07:27

kunal642 force-pushed the S3CarbonFile branch from df1a25c to 086279a Compare July 5, 2018 10:51

kunal642 force-pushed the S3CarbonFile branch from 086279a to b7da651 Compare July 5, 2018 11:01

kunal642 force-pushed the S3CarbonFile branch from b7da651 to 42ef12b Compare July 5, 2018 11:14

added s3 carbon file

fca167b

kunal642 force-pushed the S3CarbonFile branch from 42ef12b to fca167b Compare July 6, 2018 06:01

kunal642 closed this Jul 6, 2018

[CARBONDATA-2642] Added configurable Lock path property #2406

[CARBONDATA-2642] Added configurable Lock path property #2406

Conversation

kunal642 commented Jun 25, 2018 • edited

CarbonDataQA commented Jun 25, 2018

CarbonDataQA commented Jun 25, 2018

ravipesala commented Jun 25, 2018

CarbonDataQA commented Jun 25, 2018

CarbonDataQA commented Jun 25, 2018

ravipesala commented Jun 25, 2018

CarbonDataQA commented Jun 25, 2018

CarbonDataQA commented Jun 25, 2018

CarbonDataQA commented Jun 25, 2018

ravipesala commented Jun 25, 2018

CarbonDataQA commented Jun 25, 2018

CarbonDataQA commented Jun 25, 2018

CarbonDataQA commented Jun 26, 2018

CarbonDataQA commented Jun 26, 2018

ravipesala commented Jun 26, 2018

CarbonDataQA commented Jun 26, 2018

CarbonDataQA commented Jun 26, 2018

ravipesala commented Jun 27, 2018

kunal642 commented Jun 27, 2018

CarbonDataQA commented Jun 27, 2018

CarbonDataQA commented Jun 27, 2018

CarbonDataQA commented Jun 28, 2018

kunal642 commented Jun 28, 2018

gvramana Jul 5, 2018

Choose a reason for hiding this comment

kunal642 Jul 6, 2018

Choose a reason for hiding this comment

CarbonDataQA commented Jul 5, 2018

CarbonDataQA commented Jul 5, 2018

brijoobopanna commented Jul 5, 2018

CarbonDataQA commented Jul 5, 2018

CarbonDataQA commented Jul 5, 2018

CarbonDataQA commented Jul 5, 2018

CarbonDataQA commented Jul 5, 2018

kunal642 commented Jul 5, 2018

CarbonDataQA commented Jul 5, 2018

kunal642 commented Jul 5, 2018

CarbonDataQA commented Jul 5, 2018

kunal642 commented Jul 5, 2018

ravipesala commented Jul 5, 2018

CarbonDataQA commented Jul 5, 2018

CarbonDataQA commented Jul 5, 2018

brijoobopanna commented Jul 5, 2018

ravipesala commented Jul 5, 2018

CarbonDataQA commented Jul 5, 2018

CarbonDataQA commented Jul 6, 2018

ravipesala commented Jul 6, 2018

gvramana commented Jul 6, 2018

CarbonDataQA commented Jul 7, 2018

kunal642 commented Jun 25, 2018 •

edited