Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-2512][32k] Support writing longstring through SDK #2455

Closed

Conversation

xuchuanyin
Copy link
Contributor

Support writing longstring through SDK.
User can specify the datatype as 'varchar' for longstring columns.
Please note that, the 'varchar' column cannot be sort_columns.

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

  • Any interfaces changed?
    NO

  • Any backward compatibility impacted?
    NO

  • Document update required?
    NO

  • Testing done
    Please provide details on
    - Whether new unit test cases have been added or why no new tests are required?
    Added test
    - How it is tested? Please attach test report.
    Tested in local machine
    - Is it a performance related change? Please attach the performance test report.
    No
    - Any additional information to help reviewers in testing this change.

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6869/

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5654/

Support writing longstring through SDK.
User can specify the datatype as 'varchar' for longstring columns.
Please note that, the 'varchar' column cannot be sort_columns.
@xuchuanyin xuchuanyin force-pushed the CARBONDATA-2512_sdk_longstring branch from 2558cb8 to 9b1c7a3 Compare July 7, 2018 14:25
@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6910/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5695/

@ravipesala
Copy link
Contributor

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5679/

@brijoobopanna
Copy link
Contributor

retest sdv please

@ravipesala
Copy link
Contributor

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5693/

@xuchuanyin
Copy link
Contributor Author

retest sdv please

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7098/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5874/

@jackylk
Copy link
Contributor

jackylk commented Jul 24, 2018

LGTM

@asfgit asfgit closed this in 1345dc6 Jul 24, 2018
asfgit pushed a commit that referenced this pull request Jul 30, 2018
Support writing longstring through SDK.
User can specify the datatype as 'varchar' for longstring columns.
Please note that, the 'varchar' column cannot be sort_columns.

This closes #2455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants