[CARBONDATA-2752][CARBONSTORE] Carbon provide Zeppelin support #2522
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
| rows = SparkSqlWrapper.sql(SqlHorizon.getSession(), request.getSqlStatement()) | ||
| sqlDataFrame = SparkSqlWrapper.sql(SqlHorizon.getSession(), | ||
| request.getSqlStatement()); | ||
| rows = sqlDataFrame | ||
| .collectAsList(); |
| .collectAsList(); | ||
| } catch (AnalysisException e) { | ||
| throw new StoreException(e.getSimpleMessage()); | ||
| } catch (Exception e) { | ||
| throw new StoreException(e.getMessage()); | ||
| } | ||
| Object[][] result = new Object[rows.size()][]; | ||
| Object[][] result = new Object[rows.size()+1][]; |
There was a problem hiding this comment.
add space before and after +
| for (int j = 0; j < row.size(); j++) { | ||
| result[i][j] = row.get(j); | ||
| result[i+1][j] = row.get(j); |
There was a problem hiding this comment.
Can't use System.arraycopy?
| .collectAsList(); | ||
| } catch (AnalysisException e) { | ||
| throw new StoreException(e.getSimpleMessage()); | ||
| } catch (Exception e) { | ||
| throw new StoreException(e.getMessage()); | ||
| } | ||
| Object[][] result = new Object[rows.size()][]; | ||
| Object[][] result = new Object[rows.size()+1][]; | ||
| result[0] = sqlDataFrame.schema().fieldNames(); | ||
| for (int i = 0; i < rows.size(); i++) { |
There was a problem hiding this comment.
replaced with stream construct
|
add to whitelist |
zeppelin/README.txt
Outdated
| @@ -0,0 +1,18 @@ | |||
| Please follow below steps to integrate with zeppelin | |||
There was a problem hiding this comment.
- please use .md format
- Please add apache license header also.
There was a problem hiding this comment.
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7295/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7297/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6064/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7300/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6067/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6089/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7323/ |
zeppelin/README.txt
Outdated
| @@ -0,0 +1,18 @@ | |||
| Please follow below steps to integrate with zeppelin | |||
There was a problem hiding this comment.
Is this README written for carbon specificly?
zeppelin/assembly/assembly.xml
Outdated
| @@ -0,0 +1,37 @@ | |||
| <assembly> | |||
There was a problem hiding this comment.
please move zeppelin folder to integration folder
| */ | ||
| public class CarbonInterpreter extends Interpreter { | ||
|
|
||
| public static final Logger logger = LoggerFactory.getLogger(CarbonInterpreter.class); |
There was a problem hiding this comment.
Please use Carbon's LogService
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7352/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6116/ |
|
Merged |
Apache Zeppelin is a popular open web-based notebook that enables interactive data analytics. This is one of the favored solutions for providing UI frontend as it can support solutions like Spark already. Carbon can leverage this to provide a UI for its operations. After CARBONDATA-2688 which provides a carbon REST server, we can add a UI support from zeppelin to provide a complete solution.
Document update required? YES, need to update usage guide for Zeppelin integration
Testing done