[CARBONDATA-2757][BloomDataMap] Fix bug when building bloomfilter on measure column #2526
Conversation
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7306/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6073/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7312/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6077/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5920/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5924/ |
kevinjmh
changed the title
| @@ -106,4 +109,48 @@ public void setDoublePage(double[] doubleData) { | |||
| throw new UnsupportedOperationException("invalid data type: " + dataType); | |||
| } | |||
|
|
|||
| private BigDecimal getDecimalFromRawData(int rowId) { | |||
There was a problem hiding this comment.
Please add comment to describe when to use this method and the below method
| // or `RawBytesReadSupport.readRow` with actual data type | ||
|
|
||
| // Carbon stores boolean as byte. Here we convert it for `getValueAsBytes` | ||
| if (value instanceof Boolean) { |
There was a problem hiding this comment.
can we use the datatype as the condition?
There was a problem hiding this comment.
Yes. FYI, column of boolean type uses column page with inner datatype Byte, and some disagreement on DataType exists between getData and getNull in ColumnPage. I will changed that.
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7351/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6115/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7355/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6119/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5936/ |
|
LGTM |
…measure column 1. support to get raw data from decimal column page when building datamap in loading process 2. convert decimal column to java datatype when rebuilding bloom datamap from query result 3. convert boolean to byte as carbon wants 4. fix bugs when measure column is null This closes #2526
support to get raw data from decimal column page when building datamap in loading process
convert decimal column to java datatype when rebuilding bloom datamap from query result
convert boolean to byte as carbon wants
fix bugs when measure column is null
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
Any interfaces changed?
Any backward compatibility impacted?
Document update required?
Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.