[CARBONDATA-2794]Distinct count fails on ArrayOfStruct #2573
Conversation
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7578/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6333/ |
| @@ -743,7 +743,7 @@ class CarbonLateDecodeRule extends Rule[LogicalPlan] with PredicateHelper { | |||
| attrName.contains(n) | |||
| }) | |||
| case ar : ArrayType => | |||
| attrName.contains(a.name + "[") | |||
| attrName.contains(a.name + "[") || ar.elementType.isInstanceOf[StructType] | |||
There was a problem hiding this comment.
Don't check on the outut,
Add as below to check the child types also.
attrName.contains(a.name + "[") || attrName.contains(a.name + ".")
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7583/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6338/ |
|
Retest this please |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7585/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6340/ |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6044/ |
|
LGTM |
This PR fixes Code Generator Error thrown when Select filter contains more than one count of distinct of ArrayofStruct with group by Clause This closes #2573
This PR fixes Code Generator Error thrown when Select filter contains more than one count of distinct of ArrayofStruct with group by Clause This closes apache#2573
This PR fixes Code Generator Error thrown when Select filter contains more than one count of distinct of ArrayofStruct with group by Clause
Any interfaces changed?
Any backward compatibility impacted?
Document update required?
Testing done
Testcase added
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.