[CARBONDATA-2799][BloomDataMap] Fix bugs in querying with bloom datamap on preagg with dictionary column #2580
Conversation
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7612/ |
|
retest this please |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7635/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6356/ |
|
retest this please |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7647/ |
|
retest it please |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6376/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7671/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6401/ |
|
retest sdv please |
For preaggregate table, if the groupby column is dictionary column in parent table, the preaggregate table will inherit the dictionary encoding as well as the dictionary file from the parent table. So for dictionary columns, during query with bloom, we need to convert the plain filter value to dictionarty encoded value based on parent table's dictionary file.
xuchuanyin
force-pushed
the
0730_bug_bloom_preagg
branch
from
eac5b4d
to
e28b319
Compare
|
conflicts resolved |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7697/ |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6092/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6423/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7727/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6453/ |
|
LGTM |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6120/ |
…ap on preagg with dictionary column For preaggregate table, if the groupby column is dictionary column in parent table, the preaggregate table will inherit the dictionary encoding as well as the dictionary file from the parent table. So for dictionary columns, during query with bloom, we need to convert the plain filter value to dictionarty encoded value based on parent table's dictionary file. This closes #2580
For preaggregate table, if the groupby column is dictionary column in
parent table, the preaggregate table will inherit the dictionary
encoding as well as the dictionary file from the parent table.
So for dictionary columns, during query with bloom, we need to
convert the plain filter value to dictionarty encoded value based on
parent table's dictionary file.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
NONONOPlease provide details on
- Whether new unit test cases have been added or why no new tests are required?
Added test- How it is tested? Please attach test report.
Tested in local machine- Is it a performance related change? Please attach the performance test report.
NO- Any additional information to help reviewers in testing this change.
NANA