Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-2800][Doc] Add useful tips about bloomfilter datamap #2581

Closed
wants to merge 3 commits into from

Conversation

xuchuanyin
Copy link
Contributor

add useful tips about bloomfilter datamap

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

  • Any interfaces changed?
    NO

  • Any backward compatibility impacted?
    NO

  • Document update required?
    Yes, updated the document

  • Testing done
    Please provide details on
    - Whether new unit test cases have been added or why no new tests are required?
    NA
    - How it is tested? Please attach test report.
    NA
    - Is it a performance related change? Please attach the performance test report.
    NA
    - Any additional information to help reviewers in testing this change.
    NA

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

add useful tips about bloomfilter datamap
@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7620/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6355/

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7649/

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6375/

@@ -125,6 +125,10 @@
TBLPROPERTIES ('SORT_COLUMNS'='Dime_1, HOST, MSISDN')
```

**NOTE:**
+ BloomFilter can be created to enhance performance for queries with precise equal/in conditions. You can find more information about it in BloomFilter datamap document.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add one link to bloomfilter datamap document.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Notice that bigger `BLOOM_SIZE` will increase the size of index file
and smaller `BLOOM_FPP` will increase runtime calculation while performing query.
+ '0' skipped blocklets of BloomFilter datamap in explain output indicates that
BloomFilter datamap does not prune better than Main datamap.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BloomFilter datamap does not prune better than Main datamap. -- can you provide more detail about this point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an example scenario

@ravipesala
Copy link
Contributor

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6075/

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7668/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6400/

@brijoobopanna
Copy link
Contributor

retest sdv please

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7701/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6427/

@ravipesala
Copy link
Contributor

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6094/

@jackylk
Copy link
Contributor

jackylk commented Aug 1, 2018

LGTM

@asfgit asfgit closed this in a302cd1 Aug 1, 2018
sgururajshetty pushed a commit to sgururajshetty/carbondata that referenced this pull request Aug 2, 2018
add useful tips about bloomfilter datamap

This closes apache#2581
asfgit pushed a commit that referenced this pull request Aug 9, 2018
add useful tips about bloomfilter datamap

This closes #2581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants