[CARBONDATA-2817]Thread Leak in Update and in No sort flow #2606
Conversation
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7748/ |
| @@ -80,11 +82,16 @@ | |||
|
|
|||
| private Map<String, LocalDictionaryGenerator> localDictionaryGeneratorMap; | |||
|
|
|||
| private List<CarbonFactHandler> carbonFactHandlers; | |||
|
|
|||
| ExecutorService executorService = null; | |||
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6473/ |
BJangir
force-pushed
the
update_threadLeak
branch
2 times, most recently
from
93e4e9d
to
fe7b343
Compare
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7772/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6496/ |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6137/ |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6153/ |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6155/ |
|
retest this please |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7785/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6510/ |
| } | ||
|
|
||
| @Override protected String getStepName() { | ||
| return "Data Writer"; | ||
| } | ||
|
|
||
| private void finish(CarbonFactHandler dataHandler, int iteratorIndex) { | ||
| CarbonDataWriterException exception = null; |
There was a problem hiding this comment.
Please handle for closeHandler method as it can also throw exception
|
@BJangir Please handle thread leak scenario for BatchSortWriter in case of any exception. DataWriterBatchProcessorStepImpl.java |
BJangir
force-pushed
the
update_threadLeak
branch
from
fe7b343
to
8fb2432
Compare
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6193/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7817/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6541/ |
|
retest this please |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7830/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6555/ |
| if (!rowsNotExist) { | ||
| finish(dataHandler, iteratorIndex); | ||
| } | ||
| } catch (CarbonDataWriterException e) { |
There was a problem hiding this comment.
remove this catch block
BJangir
force-pushed
the
update_threadLeak
branch
from
8fb2432
to
9ac53d0
Compare
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6209/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7835/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6560/ |
|
LGTM |
Issue :- After Update Command is finished , Loading threads are not getting stopped. Root Cause :- In Update flow DataLoadExecutor 's close method is not called so all Executors services are not closed. In Exceptions are not handled property in AFDW class's closeExecutorService() which is cuasing Thread leak if Job is killed from SparkUI.. Solution :- Add Task Completion Listener and call close method of DataLoadExecutor to it . Handle Exception in closeExecutor Service so that all Writer steps Threads can be closed. This closes #2606
Issue :- After Update Command is finished , Loading threads are not getting stopped.
Root Cause :-
Solution :-
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
NO
NO
NO
Verified in cluster manually .
NA