Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-2831] Added Support Merge index files read from non transactional table #2610

Closed
wants to merge 3 commits into from

Conversation

ajantha-bhat
Copy link
Member

problem : Currently SDK read/ nontransactional table read from external
table gives null output when carbonMergeindex file is present instead of
carobnindex files.

cause : In LatestFileReadCommitted, while taking snapshot, merge index
files were not considered.

solution: consider the merge index files while taking snapshot

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

  • Any interfaces changed? NA

  • Any backward compatibility impacted? NA

  • Document update required? NA

  • Testing done. Added UT

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA

…actional table.

problem : Currently  SDK read/ nontransactional table read from external
table gives null output when carbonMergeindex file is present instead of
carobnindex files.

cause : In LatestFileReadCommitted, while taking snapshot, merge index
files were not considered.

solution: consider the merge index files while taking snapshot
@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6173/

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7793/

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6518/

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6179/

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7800/

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6524/

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6185/

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7808/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6532/

@ajantha-bhat
Copy link
Member Author

retest this please

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7812/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6536/

@ajantha-bhat
Copy link
Member Author

retest this please

@ravipesala
Copy link
Contributor

LGTM

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6543/

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7819/

@asfgit asfgit closed this in ed22508 Aug 7, 2018
asfgit pushed a commit that referenced this pull request Aug 9, 2018
…actional table

problem : Currently SDK read/ nontransactional table read from external
table gives null output when carbonMergeindex file is present instead of
carobnindex files.

cause : In LatestFileReadCommitted, while taking snapshot, merge index
files were not considered.

solution: consider the merge index files while taking snapshot

This closes #2610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants