[CARBONDATA-2866] Block schema in external table #2645
Conversation
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6299/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7948/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6672/ |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6302/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7950/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6674/ |
|
retest this please |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8267/ |
|
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/196/ |
jackylk
force-pushed
the
fix_external_table
branch
from
f892e26
to
53712b3
Compare
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8318/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/248/ |
|
LGTM |
**Changes: 1. #2645 has blocked the schema for external table. But SDV test cases were not updated. Hence updated the test cases 2. table properties was not blocked for external table, so even when a valid table property is passed, validation of table properties will fail for external table, as fields (schema) will be null. Hence blocked this with proper error message** This closes #2809
**Changes: 1. #2645 has blocked the schema for external table. But SDV test cases were not updated. Hence updated the test cases 2. table properties was not blocked for external table, so even when a valid table property is passed, validation of table properties will fail for external table, as fields (schema) will be null. Hence blocked this with proper error message** This closes #2809
This PR blocks schema in CREATE EXTERNAL TABLE.
No
No
No
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
Testcase added
NA