Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX-compatibility] Handle Lazy loading with inverted index for ColumnarVectorWrapperDirectWithInvertedIndex #2870

Closed
wants to merge 2 commits into from

Conversation

ajantha-bhat
Copy link
Member

@ajantha-bhat ajantha-bhat commented Oct 29, 2018

Problem:
Create a store with 1.4 code with inverted index and read it with vector filling (latest master code).
below exception will be thrown from AbstractCarbonColumnarVector.
UnsupportedOperationException("Not allowed from here " + getClass().getName());

cause:
when the lazy loading with an inverted index,
getBlockDataType() was not implemented for ColumnarVectorWrapperDirectWithInvertedIndex.

So, Added implementation.

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

  • Any interfaces changed? NA

  • Any backward compatibility impacted? NA

  • Document update required? NA

  • Testing done
    yes.

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA

@ajantha-bhat
Copy link
Member Author

@kumarvishal09 : please reveiw

@ajantha-bhat ajantha-bhat changed the title [HOTFIX] Handle Lazy loading with inverted index for ColumnarVectorWrapperDirectWithInvertedIndex [HOTFIX-compatibility] Handle Lazy loading with inverted index for ColumnarVectorWrapperDirectWithInvertedIndex Oct 29, 2018
@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1108/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1319/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9373/

@ajantha-bhat
Copy link
Member Author

ajantha-bhat commented Oct 29, 2018

@ravipesala : please review

It has adaptive encoding compatibility fix also

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1129/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1340/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9393/

@ravipesala
Copy link
Contributor

LGTM

1 similar comment
@kumarvishal09
Copy link
Contributor

LGTM

@asfgit asfgit closed this in 94a4f83 Oct 31, 2018
asfgit pushed a commit that referenced this pull request Nov 21, 2018
…lumnarVectorWrapperDirectWithInvertedIndex

Problem:
Create a store with 1.4 code with inverted index and read it with vector filling (latest master code).
below exception will be thrown from AbstractCarbonColumnarVector.
UnsupportedOperationException("Not allowed from here " + getClass().getName());

cause:
when the lazy loading with an inverted index,
getBlockDataType() was not implemented for ColumnarVectorWrapperDirectWithInvertedIndex.

So, Added implementation.

This closes #2870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants