[CARBONDATA-3051] Fix bugs in unclosed streams #2871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed to run CarbonReaderTests in windows env. This is due to two problems in carbondata: Problem 1: While encountering problems, we should close all the streams instead of only close current one. Problem 2: Current FileReader is not singleton nor the fileCache variable is a class variable, so it can only provide cache function if we pass the object among the methods. After reading version info, the fileReader cannot be used by other methods, so we must close it.
xuchuanyin
force-pushed
the
181029_bug_close_stream
branch
from
bf966bc
to
787fa98
Compare
|
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9372/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1111/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1322/ |
|
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9376/ |
jackylk
reviewed
Oct 30, 2018
| @@ -169,7 +170,7 @@ public CarbonReaderBuilder withHadoopConf(String key, String value) { | |||
| reader.initialize(split, attempt); | |||
| readers.add(reader); | |||
| } catch (Exception e) { | |||
| reader.close(); | |||
| CarbonUtil.closeStreams(readers.toArray(new RecordReader[0])); | |||
There was a problem hiding this comment.
Why not loop and close each one in the readers?
There was a problem hiding this comment.
CarbonUtil.closeStreams will loop and close the readers. Calling this will save the loc (line of code)
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Nov 21, 2018
Failed to run CarbonReaderTests in windows env. This is due to two problems in carbondata: Problem 1: While encountering problems, we should close all the streams instead of only close current one. Problem 2: Current FileReader is not singleton nor the fileCache variable is a class variable, so it can only provide cache function if we pass the object among the methods. After reading version info, the fileReader cannot be used by other methods, so we must close it. This closes #2871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed to run CarbonReaderTests in windows env. This is due to two
problems in carbondata:
Problem 1: While encountering problems, we should close all the streams instead of
only close current one.
Problem 2: Current FileReader is not singleton nor the fileCache
variable is a class variable, so it can only provide cache function if
we pass the object among the methods. After reading version info, the
fileReader cannot be used by other methods, so we must close it.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
NANANAPlease provide details on
- Whether new unit test cases have been added or why no new tests are required?
NA, only fix bugs- How it is tested? Please attach test report.
Tested in local machine- Is it a performance related change? Please attach the performance test report.
NA- Any additional information to help reviewers in testing this change.
NANA