Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CARBONDATA-3002] Fix some spell error #2890

Closed
wants to merge 3 commits into from
Closed

[CARBONDATA-3002] Fix some spell error #2890

wants to merge 3 commits into from

Conversation

xubo245
Copy link
Contributor

@xubo245 xubo245 commented Nov 1, 2018 •
edited

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

  • Any interfaces changed?
    No
  • Any backward compatibility impacted?
    No
  • Document update required?
    No
  • Testing done
    only change spell error
  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    No

@xubo245 xubo245 force-pushed the CARBONDATA-3002_FixSpellError3 branch from ac897eb to 9a11df9 Compare November 1, 2018 03:27
@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1203/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9467/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1418/

@chenliang613
Copy link
Contributor

LGTM

@xubo245
Copy link
Contributor Author

xubo245 commented Nov 6, 2018

@chenliang613 @jackylk How to handle this PR?

@xubo245 xubo245 force-pushed the CARBONDATA-3002_FixSpellError3 branch from 9a11df9 to 1198831 Compare November 12, 2018 08:18
@xubo245
Copy link
Contributor Author

xubo245 commented Nov 12, 2018

rebase

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1363/

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1573/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9621/

@xubo245
Copy link
Contributor Author

xubo245 commented Nov 12, 2018

retest this please

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1367/

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1577/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9625/

@xubo245
Copy link
Contributor Author

xubo245 commented Nov 12, 2018

retest this please

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1370/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9627/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1579/

@xubo245
Copy link
Contributor Author

xubo245 commented Nov 12, 2018

@jackylk @chenliang613 CI pass, please handle it.

1 similar comment
@xubo245
Copy link
Contributor Author

xubo245 commented Dec 3, 2018

@jackylk @chenliang613 CI pass, please handle it.

@brijoobopanna
Copy link
Contributor

retest this please

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1961/

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1750/

@CarbonDataQA
Copy link

Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10009/

@xubo245 xubo245 force-pushed the CARBONDATA-3002_FixSpellError3 branch from 1198831 to 6e44622 Compare December 14, 2018 07:07
@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1756/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1967/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10015/

@xubo245
Copy link
Contributor Author

xubo245 commented Dec 14, 2018

@brijoobopanna @chenliang613 @jackylk CI pass. please check again.

jackylk
jackylk reviewed Dec 14, 2018
View reviewed changes
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java Outdated
@@ -569,25 +569,25 @@ public static Dictionary getDictionary(AbsoluteTableIdentifier absoluteTableIden
nodes.add(relation.getNode());
}

int noofNodes = (-1 == noOfNodesInput) ? nodes.size() : noOfNodesInput;
int noOfNodes = (-1 == noOfNodesInput) ? nodes.size() : noOfNodesInput;
Copy link
Contributor

@jackylk jackylk Dec 14, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
int noOfNodes = (-1 == noOfNodesInput) ? nodes.size() : noOfNodesInput;
int numNodes = (-1 == numNodesInput) ? nodes.size() : numNodesInput;

Copy link
Contributor Author

@xubo245 xubo245 Dec 14, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed noOfNodes to numOfNodes, there are more than 100+ place use numOf__,
Do I need optimize noOfXXX to numOfXXX in similar code?

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1771/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10031/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1984/

@chenliang613
Copy link
Contributor

LGTM

@asfgit asfgit closed this in 3ff61ca Dec 15, 2018
asfgit pushed a commit that referenced this pull request Dec 17, 2018
@xubo245 @sraghunandan
[CARBONDATA-3002] Fix some spell error
313ba0e 
Fix some spell error

This closes #2890
qiuchenjian pushed a commit to qiuchenjian/carbondata that referenced this pull request Jun 14, 2019
@xubo245 @qiuchenjian
[CARBONDATA-3002] Fix some spell error
6d03f91 
Fix some spell error

This closes apache#2890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackylk jackylk jackylk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xubo245 @CarbonDataQA @chenliang613 @brijoobopanna @jackylk