[HOTFIX] Improve log message in CarbonWriterBuilder #2920
Conversation
|
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1614/ |
|
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9662/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1404/ |
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
Outdated
Show resolved
Hide resolved
…riterBuilder.java
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1405/ |
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
Outdated
Show resolved
Hide resolved
| "AppName is not set, please use writtenBy() API to set the App Name" | ||
| + "which is using SDK"); | ||
| "'writtenBy' must be set when writting carbon files, use writtenBy() API to " | ||
| + "set it, it can be the application name which using the SDK"); |
There was a problem hiding this comment.
it can be the name of the application which uses the SDK.
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1615/ |
|
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9663/ |
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
Outdated
Show resolved
Hide resolved
…riterBuilder.java
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1406/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1616/ |
|
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9664/ |
…riterBuilder.java Co-Authored-By: jackylk <jacky.likun@huawei.com>
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1435/ |
|
LGTM |
|
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9693/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1645/ |
|
LGTM |
In master the log message is not proper: AppName is not set, please use writtenBy() API to set the App Namewhich is using SDK This closes #2920
In master the log message is not proper:
AppName is not set, please use writtenBy() API to set the App Namewhich is using SDKThis PR improves log message in CarbonWriterBuilder
No
No
No
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
rerun all test
NA