Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX]Fix Describe Formatted Testcases #2932

Closed
wants to merge 1 commit into from
Closed

[HOTFIX]Fix Describe Formatted Testcases #2932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,9 +230,9 @@ private List<AbstractIndex> getDataBlocks(QueryModel queryModel) throws IOExcept
updateColumns(queryModel, fileFooter.getColumnInTable(), blockInfo.getFilePath());
filePathToSegmentPropertiesMap.put(blockInfo.getFilePath(), segmentProperties);
}
LOGGER.warn("Skipping Direct Vector Filling as it is not Supported "
+ "for Legacy store prior to V3 store");
if (blockletDetailInfo.isLegacyStore()) {
LOGGER.warn("Skipping Direct Vector Filling as it is not Supported "
+ "for Legacy store prior to V3 store");
queryModel.setDirectVectorFill(false);
}
readAndFillBlockletInfo(tableBlockInfos, blockInfo,
Expand Down
8 changes: 4 additions & 4 deletions .../org/apache/carbondata/cluster/sdv/generated/CreateTableWithLocalDictionaryTestCase.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1480,7 +1480,7 @@ class CreateTableWithLocalDictionaryTestCase extends QueryTest with BeforeAndAft
descLoc.find(_.get(0).toString.contains("Local Dictionary Enabled")) match {
case Some(row) => assert(row.get(1).toString.contains("false"))
}
descLoc.find(_.get(0).toString.contains("SORT_SCOPE")) match {
descLoc.find(_.get(0).toString.contains("Sort Scope")) match {
case Some(row) => assert(row.get(1).toString.contains("global_sort"))
}
}
Expand All @@ -1500,7 +1500,7 @@ class CreateTableWithLocalDictionaryTestCase extends QueryTest with BeforeAndAft
descLoc.find(_.get(0).toString.contains("Local Dictionary Enabled")) match {
case Some(row) => assert(row.get(1).toString.contains("false"))
}
descLoc.find(_.get(0).toString.contains("SORT_SCOPE")) match {
descLoc.find(_.get(0).toString.contains("Sort Scope")) match {
case Some(row) => assert(row.get(1).toString.contains("batch_sort"))
}
}
Expand All @@ -1519,7 +1519,7 @@ class CreateTableWithLocalDictionaryTestCase extends QueryTest with BeforeAndAft
descLoc.find(_.get(0).toString.contains("Local Dictionary Enabled")) match {
case Some(row) => assert(row.get(1).toString.contains("false"))
}
descLoc.find(_.get(0).toString.contains("SORT_SCOPE")) match {
descLoc.find(_.get(0).toString.contains("Sort Scope")) match {
case Some(row) => assert(row.get(1).toString.contains("no_sort"))
}
}
Expand All @@ -1538,7 +1538,7 @@ class CreateTableWithLocalDictionaryTestCase extends QueryTest with BeforeAndAft
descLoc.find(_.get(0).toString.contains("Local Dictionary Enabled")) match {
case Some(row) => assert(row.get(1).toString.contains("false"))
}
descLoc.find(_.get(0).toString.contains("SORT_SCOPE")) match {
descLoc.find(_.get(0).toString.contains("Sort Scope")) match {
case Some(row) => assert(row.get(1).toString.contains("local_sort"))
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...est/src/test/scala/org/apache/carbondata/cluster/sdv/generated/PreAggregateTestCase.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class PreAggregateTestCase extends QueryTest with BeforeAndAfterEach {
//test to check existence of datamap
test("PreAggregateTestCase_TC001", Include) {
Assert.assertEquals(sql("show datamap on table PreAggMain").count(), 5)
checkExistence(sql("Describe formatted PreAggMain_PreAggSum"), true, "DICTIONARY")
checkExistence(sql("Describe formatted PreAggMain_PreAggSum"), true, "Dictionary")
}

//check for load data should reflects in all preaggregate tables
Expand Down