Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-3114]Remove Null Values for a Dictionary_Include Timestamp column for Range Filters #2937

Closed
wants to merge 1 commit into from

Conversation

Indhumathi27
Copy link
Contributor

@Indhumathi27 Indhumathi27 commented Nov 21, 2018

Problem:
Null Values are not removed in case of RangeFilters, if column is a dictionary and no_inverted_index timestamp column.
Solution:
Remove NULL values in case of RangeFilters for such dictionary and no_inverted_index timestamp column.

  • Any interfaces changed?

  • Any backward compatibility impacted?

  • Document update required?

  • Testing done

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1483/

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1693/

@CarbonDataQA
Copy link

Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9741/

@Indhumathi27 Indhumathi27 changed the title [CARBONDATA-3114]Remove Null Values in all types of columns for Range Filters [WIP]Remove Null Values in all types of columns for Range Filters Nov 21, 2018
@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1485/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9743/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1695/

@Indhumathi27 Indhumathi27 force-pushed the timestamp_di branch 2 times, most recently from ce70f23 to 3bca0f7 Compare November 21, 2018 15:25
@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1492/

@Indhumathi27 Indhumathi27 changed the title [WIP]Remove Null Values in all types of columns for Range Filters [WIP]Remove Null Values for a Dictionary_Include Timestamp column for Range Filters Nov 21, 2018
@Indhumathi27 Indhumathi27 changed the title [WIP]Remove Null Values for a Dictionary_Include Timestamp column for Range Filters [CARBONDATA-3114]Remove Null Values for a Dictionary_Include Timestamp column for Range Filters Nov 21, 2018
@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1493/

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1495/

@CarbonDataQA
Copy link

Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9752/

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1704/

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1506/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9765/

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1717/

@Indhumathi27
Copy link
Contributor Author

Retest this please

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1508/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9766/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1718/

@kumarvishal09
Copy link
Contributor

LGTM

@asfgit asfgit closed this in 50ecb83 Nov 22, 2018
asfgit pushed a commit that referenced this pull request Nov 30, 2018
…p column for Range Filters

Problem:
Null Values are not removed in case of RangeFilters, if column is a dictionary and no_inverted_index timestamp column.
Solution:
Remove NULL values in case of RangeFilters for such dictionary and no_inverted_index timestamp column.

This closes #2937
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants