Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CARBONDATA-3120]Fixed the parent version error in MV module #2943

Closed
wants to merge 2 commits into from
Closed

[CARBONDATA-3120]Fixed the parent version error in MV module #2943

wants to merge 2 commits into from

Conversation

Jonathan-Wei
Copy link
Contributor

@Jonathan-Wei Jonathan-Wei commented Nov 22, 2018 •
edited

fix carbondata 1.5.1 Datamap's core and plan project, pom.xml version mismatch problem.
Update version 1.5.0 to 1.5.2-SNAPSHOT

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

  • Any interfaces changed?
    No
  • Any backward compatibility impacted?
    No
  • Document update required?
    NO
  • Testing done
    Please provide details on
    - Whether new unit test cases have been added or why no new tests are required?
    - How it is tested? Please attach test report.
    - Is it a performance related change? Please attach the performance test report.
    - Any additional information to help reviewers in testing this change.
    No
  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    No

@Jonathan-Wei
fix CARBONDATA-3120
2fe4e0d 
fix carbondata 1.5.1 Datamap's core and plan project, pom.xml version mismatch problem.
Update version 1.5.0 to 1.5.1
@CarbonDataQA
Copy link

Can one of the admins verify this patch?

@xubo245
Copy link
Contributor

xubo245 commented Nov 22, 2018

Can you optimize the title? simplify . and describe details in content. What's more, please finish the checklist.

@Jonathan-Wei Jonathan-Wei changed the title [CARBONDATA-3120]apache-carbondata-1.5.1-rc1.tar.gz Datamap's core and plan project, pom.xml, is version 1.5.0, which results in an inability to compile properly [CARBONDATA-3120]Fixed mv pom.xml version mismatch problem Nov 22, 2018
@Jonathan-Wei
Copy link
Contributor Author

Jonathan-Wei commented Nov 22, 2018 •
edited

I download the apache-carbondata-1.5.1-rc1.tar.gz package.
After decompression, the datamap mv/core mv/plan project was added to the main pom for compilation。
But the But the compilation failed。
I check the pom file, parent.version is 1.5.0-snapshot. But apache-carbondata-1.5.1-rc1.tar.gz is 1.5.1.

@Jonathan-Wei Jonathan-Wei changed the title [CARBONDATA-3120]Fixed mv pom.xml version mismatch problem [CARBONDATA-3120]Fixed Fix the parent version error in MV module Nov 22, 2018
@Jonathan-Wei Jonathan-Wei changed the title [CARBONDATA-3120]Fixed Fix the parent version error in MV module [CARBONDATA-3120]Fixed the parent version error in MV module Nov 22, 2018
@brijoobopanna
Copy link
Contributor

retest this please

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1724/

@CarbonDataQA
Copy link

Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9772/

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1514/

zzcclp
zzcclp reviewed Nov 22, 2018
View reviewed changes
datamap/mv/core/pom.xml Outdated
@@ -22,7 +22,7 @@
<parent>
<groupId>org.apache.carbondata</groupId>
<artifactId>carbondata-parent</artifactId>
<version>1.5.0-SNAPSHOT</version>
<version>1.5.1</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use 1.5.2-SNAPSHOT, not 1.5.1, the same as other module.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package version I downloaded was 1.5.1.
apache-carbondata-1.5.1-rc1.tar.gz

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package version you downloaded is from a tag, not from branch-1.5.
the version of all modules on branch-1.5 is 1.5.2-SNAPSHOT, when to be released, version manager will change version to 1.5.1 to tag a version package.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravipesala @sraghunandan Have you tested MV module before/when we release 1.5.1-rc1? Why didn't change it?

zzcclp
zzcclp reviewed Nov 22, 2018
View reviewed changes
datamap/mv/plan/pom.xml Outdated
@@ -22,7 +22,7 @@
<parent>
<groupId>org.apache.carbondata</groupId>
<artifactId>carbondata-parent</artifactId>
<version>1.5.0-SNAPSHOT</version>
<version>1.5.1</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use 1.5.2-SNAPSHOT, not 1.5.1, the same as other module.

@xubo245
Copy link
Contributor

xubo245 commented Nov 23, 2018 •
edited

please change the content：Update version 1.5.0 to 1.5.1
=》Update version 1.5.0 to 1.5.2-SNAPSHOT @Jonathan-Wei

@xubo245
Copy link
Contributor

xubo245 commented Nov 23, 2018

retest this please

@Jonathan-Wei Jonathan-Wei changed the title [CARBONDATA-3120]Fixed the parent version error in MV module [CARBONDATA-3120]Update version 1.5.0 to 1.5.1 =》Update version 1.5.0 to 1.5.2-SNAPSHOT Nov 23, 2018
@Jonathan-Wei Jonathan-Wei changed the title [CARBONDATA-3120]Update version 1.5.0 to 1.5.1 =》Update version 1.5.0 to 1.5.2-SNAPSHOT [CARBONDATA-3120]Fixed the parent version error in MV module Nov 23, 2018
@xubo245
Copy link
Contributor

xubo245 commented Nov 23, 2018

retest this please

2 similar comments
@zzcclp
Copy link
Contributor

zzcclp commented Nov 23, 2018

retest this please

@sraghunandan
Copy link
Contributor

retest this please

@ravipesala
Copy link
Contributor

add to whitelist

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1522/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9780/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1732/

@xubo245
Copy link
Contributor

xubo245 commented Nov 23, 2018

LGTM

@xuchuanyin
Copy link
Contributor

This PR uses the version 1.5.2-snapshot, but the main pom uses 1.6.0-snapshot.
Is it intended?

@xubo245
Copy link
Contributor

xubo245 commented Nov 23, 2018

this PR is pushed to branch1.5.not master

asfgit pushed a commit that referenced this pull request Nov 23, 2018
@Jonathan-Wei @zzcclp
[CARBONDATA-3120] Fixed the parent version error in MV module
5ab58ec 
fix carbondata 1.5.1 Datamap's core and plan project, pom.xml version mismatch problem.
Update version 1.5.0 to 1.5.1

This closes #2943
@zzcclp
Copy link
Contributor

zzcclp commented Nov 23, 2018

LGTM

@Jonathan-Wei
Copy link
Contributor Author

Fixed.

asfgit pushed a commit that referenced this pull request Nov 30, 2018
@Jonathan-Wei @ravipesala
[CARBONDATA-3120] Fixed the parent version error in MV module
920f057 
fix carbondata 1.5.1 Datamap's core and plan project, pom.xml version mismatch problem.
Update version 1.5.0 to 1.5.1

This closes #2943
asfgit pushed a commit that referenced this pull request Nov 30, 2018
@Jonathan-Wei @ravipesala
[CARBONDATA-3120] Fixed the parent version error in MV module
aa70c5b 
fix carbondata 1.5.1 Datamap's core and plan project, pom.xml version mismatch problem.
Update version 1.5.0 to 1.5.1

This closes #2943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xubo245 xubo245 xubo245 left review comments

@zzcclp zzcclp zzcclp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Jonathan-Wei @CarbonDataQA @xubo245 @brijoobopanna @zzcclp @sraghunandan @ravipesala @xuchuanyin