getOrCreateCarbonSession method parameter is an empty string repair[JIRA CARBONDATA-3119] #2959
Conversation
…scala getOrCreateCarbonSession method parameters Filter for null and empty string
…scala getOrCreateCarbonSession method parameters Filter for null and empty string
|
Can one of the admins verify this patch? |
|
Please optimize the title: [CARBONDATA-3119]Fix the error of getOrCreateCarbonSession method parameter is an empty string |
| @@ -15,58 +15,59 @@ | |||
| See the License for the specific language governing permissions and | |||
| limitations under the License. | |||
| --> | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
There was a problem hiding this comment.
no need to change, please keep the original format
| @@ -1,135 +0,0 @@ | |||
| # Presto Multinode Cluster setup For Carbondata | |||
| @@ -614,7 +614,7 @@ | |||
| <modules> | |||
| <module>integration/spark2</module> | |||
| <module>integration/hive</module> | |||
| <module>integration/presto</module> | |||
| <!--<module>integration/presto</module>--> | |||
There was a problem hiding this comment.
no need to change, please keep the original format
| @@ -556,7 +556,7 @@ | |||
| <modules> | |||
| <module>integration/spark2</module> | |||
| <module>integration/hive</module> | |||
| <module>integration/presto</module> | |||
| <!--<module>integration/presto</module>--> | |||
There was a problem hiding this comment.
no need to change, please keep the original format
| @@ -496,7 +496,7 @@ | |||
| <modules> | |||
| <module>integration/spark2</module> | |||
| <module>integration/hive</module> | |||
| <module>integration/presto</module> | |||
| <!--<module>integration/presto</module>--> | |||
There was a problem hiding this comment.
no need to change, please keep the original format
| @@ -463,7 +463,7 @@ | |||
| <module>integration/spark2</module> | |||
| <module>examples/spark2</module> | |||
| <module>integration/hive</module> | |||
| <module>integration/presto</module> | |||
| <!--<module>integration/presto</module>--> | |||
There was a problem hiding this comment.
no need to change, please keep the original format
| /** | ||
| * It is a hack to get the private field from class. | ||
| */ | ||
| /** |
There was a problem hiding this comment.
no need to change, please keep the original format
| @@ -171,7 +173,7 @@ object CarbonSession { | |||
| } | |||
|
|
|||
| def getOrCreateCarbonSession(storePath: String, | |||
| metaStorePath: String): SparkSession = synchronized { | |||
| metaStorePath: String): SparkSession = synchronized { | |||
There was a problem hiding this comment.
no need to change, please keep the original format
| @@ -114,8 +115,8 @@ class CarbonSession(@transient val sc: SparkContext, | |||
| } | |||
|
|
|||
| private def withProfiler( | |||
| sqlText: String, | |||
| generateDF: (QueryExecution, SQLStart) => DataFrame): DataFrame = { | |||
| sqlText: String, | |||
There was a problem hiding this comment.
no need to change, please keep the original format
| /** | ||
| * Run SparkSQL directly | ||
| */ | ||
| /** |
There was a problem hiding this comment.
no need to change, please keep the original format
| * Return true if the specified sql statement will hit the datamap | ||
| * This API is for test purpose only | ||
| */ | ||
| /** |
There was a problem hiding this comment.
no need to change, please keep the original format
1.No interface changes
2.Backward compatibility is not affected
3.The document does not need to be updated
val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession("")
val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession(" ")
carbon.sql("SELECT * FROM TABLE").show() is ok.