[HOTFIX] remove this useless assignment #3017
Conversation
|
|
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1910/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10164/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2121/ |
| @@ -112,7 +112,7 @@ public LocalFileLock(String lockFileLocation, String lockFile) { | |||
| status = true; | |||
| } | |||
| } catch (IOException e) { | |||
| status = false; | |||
| // status = false; | |||
There was a problem hiding this comment.
Should it print error message for IOException ?
There was a problem hiding this comment.
I suggest we print a warning message, and remove this assignment
@ravipesala @QiangCai
There was a problem hiding this comment.
I suggest we print a warning message, and remove this assignment
@ravipesala @QiangCai
ok, I saw some exception just catch, not print message. so I think it's no need here before, like HdfsFileLock
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
Please review PR #2878 at your convenience. Changes follows rules in the table in description
|
hi, @jackylk, I think this may be part of code style as we talk about in wechat group. So need someone control the progress of code style |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1957/ |
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
Any interfaces changed? NO
Any backward compatibility impacted? NO
Document update required? NO
Testing done YES
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. OK