Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-3230] Add alter test case for datasource #3024

Closed
wants to merge 2 commits into from

Conversation

xubo245
Copy link
Contributor

@xubo245 xubo245 commented Dec 26, 2018

[CARBONDATA-3230] Add ALTER test case with datasource for using parquet and carbon

1.add column. => carbon and parquet don't support, limit from Spark
2.drop column => carbon doesn't support in sql, limit from Spark, but using DF is ok; parquet use DF is ok, but sql doesn't support iy.
3.rename column =》 carbon and parquet support it.
4.change datatype of column => carbon parquet doesn't support, limit from Spark, spark only support change comment

Add test case for carbon and parquet.

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

  • Any interfaces changed?
    No
  • Any backward compatibility impacted?
    No
  • Document update required?
    No
  • Testing done
    Please provide details on
    - Whether new unit test cases have been added or why no new tests are required?
    - How it is tested? Please attach test report.
    - Is it a performance related change? Please attach the performance test report.
    - Any additional information to help reviewers in testing this change.
    added
  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    No

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1941/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10194/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2150/

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1950/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10203/

@ravipesala
Copy link
Contributor

ravipesala commented Dec 27, 2018

@xubo245 can you more tests related to drop column, rename column , change datatype of column also here. And also for rename table as well.

@xubo245
Copy link
Contributor Author

xubo245 commented Dec 27, 2018

@ravipesala OK

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2225/

@xubo245 xubo245 changed the title [WIP] Add ALTER ADD COLUMNS test case for using parquet and carbon [WIP][CARBONDATA-3230] Add ALTER ADD COLUMNS test case for using parquet and carbon Jan 4, 2019
@xubo245 xubo245 changed the title [WIP][CARBONDATA-3230] Add ALTER ADD COLUMNS test case for using parquet and carbon [WIP][CARBONDATA-3230] Add alter test case for datasource Jan 4, 2019
…et and carbon

1.add column
2.drop column
3.rename column
4.change datatype of column
@xubo245 xubo245 changed the title [WIP][CARBONDATA-3230] Add alter test case for datasource [CARBONDATA-3230] Add alter test case for datasource Jan 4, 2019
@xubo245
Copy link
Contributor Author

xubo245 commented Jan 4, 2019

@ravipesala add test case in this PR:

1.add column
2.drop column
3.rename column
4.change datatype of column

Add test case for carbon and parquet.

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2169/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2384/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10424/

@xubo245
Copy link
Contributor Author

xubo245 commented Jan 4, 2019

@KanakaKumar @ravipesala Please review it.

@ravipesala
Copy link
Contributor

LGTM

@asfgit asfgit closed this in 4e27b86 Jan 8, 2019
asfgit pushed a commit that referenced this pull request Jan 21, 2019
[CARBONDATA-3230] Add ALTER test case with datasource for using parquet and carbon

1.add column. => carbon and parquet don't support, limit from Spark
2.drop column => carbon doesn't support in sql, limit from Spark, but using DF is ok; parquet use DF is ok, but sql doesn't support iy.
3.rename column =》 carbon and parquet support it.
4.change datatype of column => carbon parquet doesn't support, limit from Spark, spark only support change comment

This closes #3024
qiuchenjian pushed a commit to qiuchenjian/carbondata that referenced this pull request Jun 14, 2019
[CARBONDATA-3230] Add ALTER test case with datasource for using parquet and carbon

1.add column. => carbon and parquet don't support, limit from Spark
2.drop column => carbon doesn't support in sql, limit from Spark, but using DF is ok; parquet use DF is ok, but sql doesn't support iy.
3.rename column =》 carbon and parquet support it.
4.change datatype of column => carbon parquet doesn't support, limit from Spark, spark only support change comment

This closes apache#3024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants