[CARBONDATA-3223] Fixed Wrong Datasize and Indexsize calculation for old store using Show Segments #3047
Conversation
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2124/ |
|
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2330/ |
|
Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10378/ |
| (dataIndexSize.get(CarbonCommonConstants.CARBON_TOTAL_DATA_SIZE).toLong, | ||
| dataIndexSize.get(CarbonCommonConstants.CARBON_TOTAL_INDEX_SIZE).toLong) | ||
| } else { | ||
| (load.getDataSize.toLong, |
There was a problem hiding this comment.
if one of load.getDataSize and load.getIndexSize is null, it will throw exception, i think this scene should be considered
There was a problem hiding this comment.
Yes, fixed it now.
manishnalla1994
force-pushed
the
Datasize0Issue
branch
from
6bf65d7
to
7380eaa
Compare
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2135/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10389/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2341/ |
| @@ -46,9 +47,9 @@ object CarbonStore { | |||
|
|
|||
| def showSegments( | |||
| limit: Option[String], | |||
| tablePath: String, | |||
| carbonTable: CarbonTable, | |||
There was a problem hiding this comment.
Move carbonTable as the first argument of method
| if (null == load.getDataSize || null == load.getIndexSize) { | ||
| // If either of datasize or indexsize comes to be null the we calculate the correct | ||
| // size and assign | ||
| val dataIndexSize = CarbonUtil.calculateDataIndexSize(carbonTable, false) |
There was a problem hiding this comment.
Boolean flag in the method call is to update the data and index size in the table status file. Pass the flag as true so that it computes the size and update the table status file. This will avoid calculation for each Show Segment call
manishnalla1994
force-pushed
the
Datasize0Issue
branch
from
7380eaa
to
31c682a
Compare
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2143/ |
|
LGTM...can be merged once build passes |
|
Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10397/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2349/ |
|
retest this please |
|
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2361/ |
| if (null == load.getDataSize || null == load.getIndexSize) { | ||
| // If either of datasize or indexsize comes to be null the we calculate the correct | ||
| // size and assign | ||
| val dataIndexSize = CarbonUtil.calculateDataIndexSize(carbonTable, true) |
There was a problem hiding this comment.
Show segments is a read only query. I think we should not perform write operation in a query.
So, I feel its better to calculate every time and show OR just display as not available.
There was a problem hiding this comment.
As it is a metadata function, we are just computing it once and saving it while passing TRUE in 'calculateDataIndexSize' this function. So the value computed can be used afterwards also.
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10401/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2148/ |
manishnalla1994
force-pushed
the
Datasize0Issue
branch
from
31c682a
to
49bd919
Compare
manishnalla1994
force-pushed
the
Datasize0Issue
branch
from
49bd919
to
c78f9df
Compare
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2165/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2379/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10420/ |
|
LGTM |
…old store using Show Segments Problem: Table Created and Loading on older version(1.1) was showing data-size and index-size 0B when refreshed on new version. This was because when the data-size was coming as "null" we were not computing it, directly assigning 0 value to it. Solution: Showing the old datasize and indexsize as NA. Also refactored SetQuerySegment code for better understandability. This closes #3047
…old store using Show Segments Problem: Table Created and Loading on older version(1.1) was showing data-size and index-size 0B when refreshed on new version. This was because when the data-size was coming as "null" we were not computing it, directly assigning 0 value to it. Solution: Showing the old datasize and indexsize as NA. Also refactored SetQuerySegment code for better understandability. This closes apache#3047
Problem: Table Created and Loading on older version(1.1) was showing data-size and index-size 0B when refreshed on new version. This was because when the data-size was coming as "null" we were not computing it, directly assigning 0 value to it.
Solution: Showing the old datasize and indexsize as NA.
Also refactored SetQuerySegment code for better understandability.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
Any interfaces changed?
Any backward compatibility impacted?
Document update required?
Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.