[CARBONDATA-3227] Fix some spell errors in the project #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
XiaotaoYi
changed the title
|
add to whitelist |
qiuchenjian
reviewed
Jan 6, 2019
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
Outdated
Show resolved
Hide resolved
qiuchenjian
reviewed
Jan 6, 2019
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
Outdated
Show resolved
Hide resolved
qiuchenjian
reviewed
Jan 6, 2019
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
Outdated
Show resolved
Hide resolved
qiuchenjian
reviewed
Jan 6, 2019
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
Outdated
Show resolved
Hide resolved
qiuchenjian
reviewed
Jan 6, 2019
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
Outdated
Show resolved
Hide resolved
|
add to whitelist |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2177/ |
|
@XiaotaoYi Please optimize the title, like: [CARBONDATA-3227] Fix some spell errors in the project |
XiaotaoYi
changed the title
|
Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10433/ |
|
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2392/ |
|
@XiaotaoYi Please fix the CI errors. |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2203/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2420/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10460/ |
|
LGTM! Thanks for you contribution! |
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Jan 21, 2019
Correct scala variable name in three files： carbondata\integration\spark-common\src\main\scala\org\apache\spark\sql\catalyst\CarbonDDLSqlParser.scala carbondata\integration\spark-common\src\main\scala\org\apache\carbondata\spark\util\CarbonScalaUtil.scala carbondata\integration\spark2\src\main\scala\org\apache\spark\util\AlterTableUtil.scala Change variable name from escapechar -> escapeChar optionlist -> optionList hivedefaultpartition -> hiveDefaultPartition pvalue -> pValue errormsg -> errorMsg isDetectAsDimentionDatatype -> isDetectAsDimentionDataType This closes #3052
qiuchenjian
pushed a commit
to qiuchenjian/carbondata
that referenced
this pull request
Jun 14, 2019
Correct scala variable name in three files： carbondata\integration\spark-common\src\main\scala\org\apache\spark\sql\catalyst\CarbonDDLSqlParser.scala carbondata\integration\spark-common\src\main\scala\org\apache\carbondata\spark\util\CarbonScalaUtil.scala carbondata\integration\spark2\src\main\scala\org\apache\spark\util\AlterTableUtil.scala Change variable name from escapechar -> escapeChar optionlist -> optionList hivedefaultpartition -> hiveDefaultPartition pvalue -> pValue errormsg -> errorMsg isDetectAsDimentionDatatype -> isDetectAsDimentionDataType This closes apache#3052
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct scala variable name in three files：
carbondata\integration\spark-common\src\main\scala\org\apache\spark\sql\catalyst\CarbonDDLSqlParser.scala
carbondata\integration\spark-common\src\main\scala\org\apache\carbondata\spark\util\CarbonScalaUtil.scala
carbondata\integration\spark2\src\main\scala\org\apache\spark\util\AlterTableUtil.scala
Change variable name from
escapechar -> escapeChar
optionlist -> optionList
hivedefaultpartition -> hiveDefaultPartition
pvalue -> pValue
errormsg -> errorMsg
isDetectAsDimentionDatatype -> isDetectAsDimentionDataType
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
No
No
No
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
No
No