[HOTFIX] Fix compile error after merging PR#3001 #3067
Conversation
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2261/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10519/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2480/ |
|
It seems that it does not include 'spark2/src/test/java/' when compile, I will check this. |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2273/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2492/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10531/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2276/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10535/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2496/ |
Fix compile error after merging PR#3001
zzcclp
force-pushed
the
fix_PR3001_issue
branch
from
73d7634
to
b81f297
Compare
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2277/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2497/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10536/ |
integration/spark2/pom.xml
Outdated
| @@ -194,6 +193,12 @@ | |||
| <version>2.18</version> | |||
| <!-- Note config is repeated in scalatest config --> | |||
| <configuration> | |||
| <includes> | |||
| <include>**/Test*.java</include> | |||
There was a problem hiding this comment.
Please check Scala test.
Please check why the number of test case +2?
There was a problem hiding this comment.
All of scala test cases ran.
But there are some java test cases of sub-project running twice, I will check this.
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2285/ |
|
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2505/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10544/ |
|
retest this please |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2291/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2511/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10550/ |
|
Still +2 |
|
Yup, I am trying to resolve this issue. But one suggestion: We can resolve this import error first and then I will raise another PR to resolve issue of testing twice, because it related to other sub-project too. OK? @xubo245 , @chenliang613 |
|
@zzcclp ok, scala test is ok? |
|
I think it's ok for scala test cases, you can check again. |
|
LGTM |
1 similar comment
|
LGTM |
|
Thanks for you contribution! |
Fix compile error after merging PR#3001 This closes #3067
Fix compile error after merging PR#3001 This closes apache#3067
Fix compile error after merging PR#3001
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
Any interfaces changed?
Any backward compatibility impacted?
Document update required?
Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.