[CARBONDATA-3246]Fix sdk reader issue if batch size is given as zero and vectorRead False. #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and vectorRead False.
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2410/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10669/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2637/ |
|
LGTM |
5 tasks
asfgit
pushed a commit
that referenced
this pull request
Jan 30, 2019
…and vectorRead False. Problem: SDK reader is failing if vectorRead is false and detail query batch size is given as 0. Compiler is giving stack overflow error after getting stuck in ChunkRowIterator.hasnext recurssion. Solution: Since 0 is wrong batch size, we should take DETAIL_QUERY_BATCH_SIZE_DEFAULT as the batch size This closes #3097
asfgit
pushed a commit
that referenced
this pull request
Jan 30, 2019
…and vectorRead False. Problem: SDK reader is failing if vectorRead is false and detail query batch size is given as 0. Compiler is giving stack overflow error after getting stuck in ChunkRowIterator.hasnext recurssion. Solution: Since 0 is wrong batch size, we should take DETAIL_QUERY_BATCH_SIZE_DEFAULT as the batch size This closes #3097
qiuchenjian
pushed a commit
to qiuchenjian/carbondata
that referenced
this pull request
Jun 14, 2019
…and vectorRead False. Problem: SDK reader is failing if vectorRead is false and detail query batch size is given as 0. Compiler is giving stack overflow error after getting stuck in ChunkRowIterator.hasnext recurssion. Solution: Since 0 is wrong batch size, we should take DETAIL_QUERY_BATCH_SIZE_DEFAULT as the batch size This closes apache#3097
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3070 was wrongly merged.Some earlier commit was merged rather than the original one which got LGTM. So this PR is to fix that issue.
Problem SDK reader is failing if vectorRead is false and detail query batch size is given as 0.Compiler is giving stack overflow error after getting stuck in ChunkRowIterator.hasnext recurssion.
Solution Since 0 is wrong batch size, we should take DETAIL_QUERY_BATCH_SIZE_DEFAULT as the batch size
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
Any interfaces changed?- No
Any backward compatibility impacted? - No
Document update required? - No
Testing done
added test case
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.