[CARBONDATA-3235] Fixed Alter Table Rename #3098
Conversation
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2424/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2651/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10682/ |
| @@ -61,6 +61,8 @@ private[sql] case class CarbonAlterTableRenameCommand( | |||
| } | |||
| val oldTableName = oldTableIdentifier.table.toLowerCase | |||
| val newTableName = newTableIdentifier.table.toLowerCase | |||
| val oldIdentifier = TableIdentifier(oldTableName, Some(oldDatabaseName)) | |||
There was a problem hiding this comment.
what the purpose of creating oldIdentifier and newIdentifier again?? when already both identifiers are present
https://github.com/apache/carbondata/pull/3098/files#diff-9fb2c5a8b63af8d61563a154cdfc8a3cR46
There was a problem hiding this comment.
Done refactoring for this.
NamanRastogi
force-pushed
the
hdfs_quota_fix_improv
branch
2 times, most recently
from
d073665
to
f274234
Compare
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2433/ |
NamanRastogi
force-pushed
the
hdfs_quota_fix_improv
branch
from
c6be6cd
to
7394cf9
Compare
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2434/ |
|
Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10692/ |
NamanRastogi
force-pushed
the
hdfs_quota_fix_improv
branch
from
7394cf9
to
b042e62
Compare
|
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2662/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2435/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10693/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2663/ |
|
retest this please |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2480/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2707/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10738/ |
|
LGTM |
Fixed negative scenario: Alter Table Rename Table Fail Problem: When tabe rename is success in hive, for failed in carbon data store, it would throw exception, but would not go back and undo rename in hive. Solution: A flag to keep check if hive rename has already executed, and of the code breaks after hive rename is done, go back and undo the hive rename. This closes #3098
Fixed negative scenario: Alter Table Rename Table Fail Problem: When tabe rename is success in hive, for failed in carbon data store, it would throw exception, but would not go back and undo rename in hive. Solution: A flag to keep check if hive rename has already executed, and of the code breaks after hive rename is done, go back and undo the hive rename. This closes #3098
Fixed negative scenario: Alter Table Rename Table Fail Problem: When tabe rename is success in hive, for failed in carbon data store, it would throw exception, but would not go back and undo rename in hive. Solution: A flag to keep check if hive rename has already executed, and of the code breaks after hive rename is done, go back and undo the hive rename. This closes apache#3098
Fixed a mistake in PR-2996.
Fixed negative scenario: Alter Table Rename Table Fail
Problem: When tabe rename is success in hive, for failed in carbon data store, it would throw exception, but would not go back and undo rename in hive.
Solution: A flag to keep check if hive rename has already executed, and of the code breaks after hive rename is done, go back and undo the hive rename.