[CARBONDATA-3359]Fix data mismatch issue for decimal column after delete operation #3189
Conversation
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2976/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11240/ |
|
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3209/ |
|
retest this please |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2981/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11245/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3214/ |
|
@QiangCai please review |
|
LGTM |
|
some test cases of decimal type are commented in TestAlterTableSortColumnsProperty. |
|
@QiangCai i checked the class, i didn't find any test cases either ignored or commented, are you referring the correct class?? |
| int newMeasureScale = info.measure.getMeasure().getScale(); | ||
| @Override public void fillVector(Object valuesToBeConverted, int size, | ||
| ColumnVectorInfo vectorInfo, BitSet nullBitSet, DataType pageType) { | ||
| CarbonColumnVector vector = vectorInfo.vector; |
There was a problem hiding this comment.
Can you refactor this code, move to some method
akashrn5
force-pushed
the
data_mismatch_decimal
branch
from
af813af
to
9e0c864
Compare
|
Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11308/ |
|
retest this please |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3046/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3245/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11310/ |
|
LGTM |
…ete operation Problem: after delete operation is performed, the decimal column data is wrong. This is because, during filling vector for decimal column, we were not considering the deleted rows if present any, we were filling all the row data for decimal. Solution in case of decimal, get the vector from ColumnarVectorWrapperDirectFactory and then put data, which will take care of the deleted rows This closes #3189
…ete operation Problem: after delete operation is performed, the decimal column data is wrong. This is because, during filling vector for decimal column, we were not considering the deleted rows if present any, we were filling all the row data for decimal. Solution in case of decimal, get the vector from ColumnarVectorWrapperDirectFactory and then put data, which will take care of the deleted rows This closes apache#3189
Problem:
after delete operation is performed, the decimal column data is wrong. This is because, during filling vector for decimal column, we were not considering the deleted rows if present any, we were filling all the row data for decimal.
Solution
in case of decimal, get the vector from ColumnarVectorWrapperDirectFactory and then put data, which will take care of the deleted rows
How this is tested?
Added functional test case for the issue.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
Any interfaces changed?
NA
Any backward compatibility impacted?
NA
Document update required?
NA
Testing done
Yes
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA