[CARBONDATA-3423] Validate dictionary for binary data type #3271
Conversation
it will throw exception if dictionary_include has binary column, it will not throw exception if DICTIONARY_EXCLUDE has binary column optimize
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3478/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3681/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11745/ |
|
@KanakaKumar @brijoobopanna |
| | age int, | ||
| | binaryField binary) | ||
| | STORED BY 'carbondata' | ||
| | tblproperties('dictionary_enable'='true','dictionary_include'='binaryField') |
There was a problem hiding this comment.
dictionary_enable is not a supported table property, please remove.
|
LGTM |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3714/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11780/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3509/ |
|
@KanakaKumar CI pass, please check. |
it will throw exception if dictionary_include has binary column, it will not throw exception if DICTIONARY_EXCLUDE has binary column
optimize
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
No
No
yes
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
yes
No