Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-3425]Added documentation for mv #3275

Closed
wants to merge 1 commit into from

Conversation

Indhumathi27
Copy link
Contributor

Added documentation for mv datamap

  • Any interfaces changed?

  • Any backward compatibility impacted?

  • Document update required?

  • Testing done

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3495/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11765/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3699/

docs/datamap/datamap-management.md Outdated Show resolved Hide resolved
* [Data Management](#data-management-with-mv-tables)

## Quick example
Download and unzip spark-2.2.0-bin-hadoop2.7.tgz, and export $SPARK_HOME
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be here you can create a link to preaggregate doc, instead of copying the same lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akashrn5 for quick example itself?


Start spark-shell in new terminal, type :paste, then copy and run the following code.
```scala
import java.io.File
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this executed and tested?

docs/datamap/mv-datamap-guide.md Outdated Show resolved Hide resolved
docs/datamap/mv-datamap-guide.md Outdated Show resolved Hide resolved
docs/datamap/mv-datamap-guide.md Outdated Show resolved Hide resolved
docs/datamap/mv-datamap-guide.md Outdated Show resolved Hide resolved
docs/datamap/mv-datamap-guide.md Outdated Show resolved Hide resolved
docs/datamap/mv-datamap-guide.md Outdated Show resolved Hide resolved
docs/datamap/mv-datamap-guide.md Outdated Show resolved Hide resolved
@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3499/

@CarbonDataQA
Copy link

Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11770/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3704/

@Indhumathi27 Indhumathi27 force-pushed the mv_doc branch 2 times, most recently from ece7ea6 to 2589404 Compare June 13, 2019 12:06
@sgururajshetty
Copy link
Contributor

LGTM

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3548/

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3553/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11827/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3759/

@Indhumathi27 Indhumathi27 force-pushed the mv_doc branch 3 times, most recently from 4d3dd69 to 95e7452 Compare June 14, 2019 08:56
@Indhumathi27 Indhumathi27 changed the title [WIP]Added documentation for mv [CARBONDATA-3425]Added documentation for mv Jun 14, 2019
@Indhumathi27
Copy link
Contributor Author

@ravipesala Handled all comments. Please review

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3573/

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3575/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3783/

@Indhumathi27 Indhumathi27 force-pushed the mv_doc branch 4 times, most recently from bb63c52 to 8688bcc Compare June 18, 2019 10:50
@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3608/

@Indhumathi27 Indhumathi27 force-pushed the mv_doc branch 2 times, most recently from fa7b12b to 6225bb7 Compare June 18, 2019 10:55
@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3611/

@Indhumathi27 Indhumathi27 force-pushed the mv_doc branch 7 times, most recently from 7524cfe to 11fc543 Compare June 18, 2019 11:32
@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3613/

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3819/

@Indhumathi27
Copy link
Contributor Author

Retest this please

@CarbonDataQA
Copy link

Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11888/

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3614/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3821/

@xubo245
Copy link
Contributor

xubo245 commented Jun 19, 2019

retest this please

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3620/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11894/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3827/

@xubo245
Copy link
Contributor

xubo245 commented Jun 19, 2019

LGTM, thanks for your contribution!

@asfgit asfgit closed this in fc8c9d0 Jun 19, 2019
13. COLUMN_COMPRESSOR
* All columns of main table at once cannot participate in mv datamap table creation
* TableProperties can be provided in DMProperties excluding LOCAL_DICTIONARY_INCLUDE,
LOCAL_DICTIONARY_EXCLUDE, DICTIONARY_INCLUDE, DICTIONARY_EXCLUDE, INVERTED_INDEX,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Streaming property is not supported in dmproperties. This can be mentioned in this list.

```
CREATE DATAMAP agg_sales
ON TABLE sales
USING "MV"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usage of DMproperties can also be mentioned in example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants