Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-3575] optimize java code checkstyle for OperatorWrap rule #3458

Closed
wants to merge 1 commit into from
Closed

[CARBONDATA-3575] optimize java code checkstyle for OperatorWrap rule #3458

wants to merge 1 commit into from

Conversation

lamberken
Copy link
Member

@lamberken lamberken commented Nov 14, 2019

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

  • Any interfaces changed? NO

  • Any backward compatibility impacted? NO

  • Document update required? NO

  • Testing done YES
    Please provide details on
    - Whether new unit test cases have been added or why no new tests are required?
    - How it is tested? Please attach test report.
    - Is it a performance related change? Please attach the performance test report.
    - Any additional information to help reviewers in testing this change.

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NO

optimize java code checkstyle for OperatorWrap rule, for a bad style example

org.apache.carbondata.processing.loading.sort.SortStepRowHandler#convertRawRowTo3Parts

int[] dictDims
     = new int[this.dictSortDimCnt + this.dictNoSortDimCnt];

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/855/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/861/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/863/

@jackylk
Copy link
Contributor

jackylk commented Nov 15, 2019

LGTM

@asfgit asfgit closed this in 567f190 Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants