[CARBONDATA-3692] Support NoneCompression during loading data. #3623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why is this PR needed? In some cases, the data need to be uncompressed after loading into Carbondata file. In the current version, the project do not support loading data without compression. What changes were proposed in this PR? Provide a new Compressor as NoneCompressor implement the AbstractCompressor. This compressor can be set by calling CarbonProperties.getInstance().addProperty(CarbonCommonConstants.COMPRESSOR,"none"); Does this PR introduce any user interface change? Yes Is any new testcase added? Yes
Why is this PR needed?
In some cases, the data need to be uncompressed after loading into Carbondata file.
In the current version, the project do not support loading data without compression.
What changes were proposed in this PR?
Provide a new Compressor as NoneCompressor implement the AbstractCompressor.
This compressor can be set by calling
CarbonProperties.getInstance().addProperty(CarbonCommonConstants.COMPRESSOR,"none");
Does this PR introduce any user interface change?
Yes
Is any new testcase added?
Yes
Pickupolddriver
changed the title
|
Can one of the admins verify this patch? |
|
please push your changes to original PR |
|
add to whitelist |
|
@Pickupolddriver : push the review comment fixes to #3611 and close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR needed?
In some cases, the data need to be uncompressed after loading into Carbondata file.
In the current version, the project does not support loading data without compression.
It could speed up data loading form Flink to OBS by skipping compress and uncompress data.
What changes were proposed in this PR?
Provide a new Compressor as NoneCompressor implements the AbstractCompressor which will actually not compress and uncompress anything.
This compressor can be set by calling
CarbonProperties.getInstance().addProperty(CarbonCommonConstants.COMPRESSOR,"none");
Does this PR introduce any user interface change?
Is any new testcase added?