[CARBONDATA-3348] Fix the case insensitive validation for duplicate sort column. #3647
Conversation
|
Can one of the admins verify this patch? |
|
add to whitelist |
|
please add one test case |
nihal0107
changed the title
|
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2258/ |
|
the failed testcases need to change the message in assert which has changed with code modification |
|
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2264/ |
|
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2266/ |
|
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2267/ |
integration/spark/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
Outdated
Show resolved
Hide resolved
integration/spark/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
Outdated
Show resolved
Hide resolved
…ort column.
Why is this PR needed?
Currently the column name with different case(upper and lower)
is getting considered as different columns for sort properties.
What changes were proposed in this PR?
Added the case insensitive validation for duplicate sort column.
Does this PR introduce any user interface change?
No
Is any new testcase added?
Yes
|
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2275/ |
|
add to whitelist |
|
retest this please |
|
Build Failed with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/575/ |
|
retest this please |
|
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2280/ |
|
retest this please |
|
Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/579/ |
|
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2284/ |
|
LGTM |
Why is this PR needed?
Currently the column name with different case(upper and lower)
is getting considered as different columns for sort properties.
What changes were proposed in this PR?
Added the case insensitive validation for duplicate sort column.
Does this PR introduce any user interface change?
No
Is any new testcase added?
yes