Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CARBONDATA-3755]Fix clean up issue with respect to segmentMetadaInfo after update and clean files #3683

Closed
wants to merge 1 commit into from
Closed

[CARBONDATA-3755]Fix clean up issue with respect to segmentMetadaInfo after update and clean files #3683

wants to merge 1 commit into from

Conversation

akashrn5
Copy link
Contributor

@akashrn5 akashrn5 commented Mar 26, 2020 •
edited

Why is this PR needed?

  1. segmentMetadaInfo is not getting copied to new segment files written after multiple updates and clean files opearation.
  2. old segment files are not getting deleted and getting accumulated.

What changes were proposed in this PR?

  1. update the segmentMetadaInfo to new files
  2. once we write new segment file, delete the old invalid segment files.

Does this PR introduce any user interface change?

  • No

Is any new testcase added?

  • No
  • Yes

@CarbonDataQA1
Copy link

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2569/

@CarbonDataQA1
Copy link

Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/861/

@akashrn5 akashrn5 changed the title [WIP]Fix clean up issue with respect to segmentMetadaInfo [CARBONDATA-3755]Fix clean up issue with respect to segmentMetadaInfo after update and clean files Mar 27, 2020
Indhumathi27
Indhumathi27 reviewed Mar 27, 2020
View reviewed changes
core/src/main/java/org/apache/carbondata/core/mutate/CarbonUpdateUtil.java
segmentFilesToBeUpdatedLatest.add(new Segment(segment.getSegmentNo(), file));
SegmentFileStore fileStore =
new SegmentFileStore(table.getTablePath(), segment.getSegmentFileName());
segment.setSegmentMetaDataInfo(fileStore.getSegmentFile().getSegmentMetaDataInfo());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a testcase for this issue, if possible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@ydvpankaj99
Copy link
Contributor

retest this please

@CarbonDataQA1
Copy link

Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/867/

@CarbonDataQA1
Copy link

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2575/

@CarbonDataQA1
Copy link

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2579/

@CarbonDataQA1
Copy link

Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/871/

@kunal642
Copy link
Contributor

kunal642 commented Apr 3, 2020

LGTM

@asfgit asfgit closed this in 5e95231 Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Indhumathi27 Indhumathi27 Indhumathi27 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@akashrn5 @CarbonDataQA1 @ydvpankaj99 @kunal642 @Indhumathi27