Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check #3716

Closed
wants to merge 1 commit into from
Closed

[CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check #3716

wants to merge 1 commit into from

Conversation

akashrn5
Copy link
Contributor

@akashrn5 akashrn5 commented Apr 16, 2020 •
edited

Why is this PR needed?

  1. In table exists API, we catch all exceptions and say table does not exists which is wrong

What changes were proposed in this PR?

  1. Catch only NoSuchTableException fro spark and return false, for other exceptions, throw it to caller

Does this PR introduce any user interface change?

  • No

Is any new testcase added?

  • No(existing test will take care)

@akashrn5 akashrn5 force-pushed the exception branch 2 times, most recently from 7f30d00 to 51c05d3 Compare April 16, 2020 15:40
@akashrn5 akashrn5 changed the title [CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check [CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check and register NI as a function Apr 16, 2020
@CarbonDataQA1
Copy link

Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1046/

@CarbonDataQA1
Copy link

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2759/

@akashrn5 akashrn5 changed the title [CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check and register NI as a function [CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check Apr 17, 2020
@CarbonDataQA1
Copy link

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2760/

@CarbonDataQA1
Copy link

Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1047/

@jackylk
Copy link
Contributor

jackylk commented Apr 18, 2020

LGTM

@asfgit asfgit closed this in 21ee342 Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akashrn5 @CarbonDataQA1 @jackylk