[CARBONDATA-3889] Cleanup code for carbondata-streaming module #3826
Conversation
|
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1566/ |
|
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3303/ |
QiangCai
changed the title
| } else { | ||
| LOGGER.error( | ||
| "Not able to acquire the lock for stream table status updation for table " + table | ||
| "Not able to acquire the lock for stream table status update for table " + table |
There was a problem hiding this comment.
| "Not able to acquire the lock for stream table status update for table " + table | |
| "Not able to acquire the status update lock for streaming table " + table |
| @@ -95,7 +95,7 @@ | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-surefire-plugin</artifactId> | |||
| <version>2.18</version> | |||
| <!-- Note config is repeated in scalatest config --> | |||
| <!-- Note config is repeated in scala test config --> | |||
There was a problem hiding this comment.
Please add license header in this POM file
| return CarbonTablePath.isCarbonDataFile(file.getName()); | ||
| } | ||
| }); | ||
| return carbonDir.listFiles(file -> CarbonTablePath.isCarbonDataFile(file.getName())); |
There was a problem hiding this comment.
Are we target on jdk8 from now on? If yes, codes in org.apache.carbondata.common like Maps, Strings can be removed
There was a problem hiding this comment.
For carbon 2.0, the answer is yes, in my opinion.
we already used new features of jdk8(lambda, stream API)
There was a problem hiding this comment.
OK.
FYI: I check spark release note, support for Java 7 was removed since 2.2
|
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1672/ |
|
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3414/ |
|
LGTM |
Why is this PR needed?
need cleanup code in carbondata-streaming module
What changes were proposed in this PR?
Cleanup code in carbondata-streaming module
Does this PR introduce any user interface change?
Is any new testcase added?