New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CARBONDATA-3898] Support Option 'carbon.enable.mv' #3839
Conversation
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1620/ |
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3361/ |
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java
Outdated
Show resolved
Hide resolved
integration/spark/src/test/scala/org/apache/carbondata/view/MVTest.scala
Outdated
Show resolved
Hide resolved
integration/spark/src/main/scala/org/apache/spark/sql/optimizer/MVRewriteRule.scala
Show resolved
Hide resolved
367e6d6
to
d691c67
Compare
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3365/ |
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1624/ |
retest this please |
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1627/ |
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3368/ |
d691c67
to
b1f67b2
Compare
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3383/ |
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1642/ |
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
Show resolved
Hide resolved
b1f67b2
to
49346ef
Compare
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3386/ |
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1645/ |
retest this please |
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3388/ |
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1647/ |
LGTM |
1 similar comment
LGTM |
Why is this PR needed?
When MV enabled, SQL rewrite takes a lot of time, a new option 'carbon.enable.querywithmv' shall be supported, which can turn off SQL Rewrite when the configured value is false
What changes were proposed in this PR?
Add option 'carbon.enable.querywithmv', then logicplan won't be changed if configured value is false
Does this PR introduce any user interface change?
Is any new testcase added?