Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CARBONDATA-3899] Drop materialized view when executed concurrently from 4 concurrent client fails in all 4 clients. #3841

Closed
wants to merge 1 commit into from
Closed

[CARBONDATA-3899] Drop materialized view when executed concurrently from 4 concurrent client fails in all 4 clients. #3841

wants to merge 1 commit into from

Conversation

ShreelekhyaG
Copy link
Contributor

@ShreelekhyaG ShreelekhyaG commented Jul 13, 2020 •
edited

Why is this PR needed?

  1. drop materialized view when executed concurrently from 4 concurrent client fails in all 4 clients.
    Also, materialized view when created in one session and queried on another open session will not hit MV.
  2. drop mv if not exists must fail.

What changes were proposed in this PR?

  1. made view manager as a single instance for all sessions, so that changes executed from one session gets reflected in others.
  2. added check for drop mv command to throw an exception if the materialized view is not present.

Does this PR introduce any user interface change?

  • No

Is any new testcase added?

  • Yes

@CarbonDataQA1
Copy link

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1641/

@CarbonDataQA1
Copy link

Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3382/

@CarbonDataQA1
Copy link

Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1644/

@CarbonDataQA1
Copy link

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3385/

@Indhumathi27
Copy link
Contributor

@ShreelekhyaG Please create a jira and update the PR

@ShreelekhyaG ShreelekhyaG changed the title [WIP] : drop materialized view when executed concurrently from 4 concurrent c… [CARBONDATA-3899]: drop materialized view when executed concurrently from 4 concurrent c… Jul 14, 2020
@ShreelekhyaG ShreelekhyaG changed the title [CARBONDATA-3899]: drop materialized view when executed concurrently from 4 concurrent c… [CARBONDATA-3899] Drop materialized view when executed concurrently from 4 concurrent c… Jul 14, 2020
@CarbonDataQA1
Copy link

Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1680/

@CarbonDataQA1
Copy link

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3423/

@ShreelekhyaG ShreelekhyaG changed the title [CARBONDATA-3899] Drop materialized view when executed concurrently from 4 concurrent c… [CARBONDATA-3899] Drop materialized view when executed concurrently from 4 concurrent client fails in all 4 clients. Jul 17, 2020
@CarbonDataQA1
Copy link

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3457/

@CarbonDataQA1
Copy link

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1715/

@ShreelekhyaG
Copy link
Contributor Author

retest this please

@ShreelekhyaG
drop materialized view when executed concurrently from 4 concurrent c…
d79276b 
…lient fails in all 4 clients

Added Drop MV check with ifexists
@CarbonDataQA1
Copy link

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3473/

@CarbonDataQA1
Copy link

Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1731/

@VenuReddy2103
Copy link
Contributor

LGTM

1 similar comment
@akashrn5
Copy link
Contributor

LGTM

@akashrn5
Copy link
Contributor

retest this please

@CarbonDataQA1
Copy link

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3486/

@CarbonDataQA1
Copy link

Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1744/

@asfgit asfgit closed this in ea6ab28 Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akashrn5 akashrn5 akashrn5 left review comments

@VenuReddy2103 VenuReddy2103 VenuReddy2103 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ShreelekhyaG @CarbonDataQA1 @Indhumathi27 @VenuReddy2103 @akashrn5