[CARBONDATA-3889] Cleanup code typo in carbondata-spark module #3867
Conversation
|
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3526/ |
|
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1785/ |
| val lock: ICarbonLock = segmentStatusManager.getTableStatusLock | ||
| val segmentMapping: util.Map[String, util.List[String]] = | ||
| new util.HashMap[String, util.List[String]] | ||
| val viewManager = MVManagerInSpark.get(session) | ||
| try if (lock.lockWithRetries) { | ||
| LOGGER.info("Acquired lock for mv " + viewIdentifier + " for table status updation") | ||
| LOGGER.info("Acquired lock for mv " + viewIdentifier + " for table status te") |
There was a problem hiding this comment.
done, change to 'update'
| @@ -50,7 +50,7 @@ import org.apache.carbondata.events.{IndexServerLoadEvent, OperationContext, Ope | |||
| import org.apache.carbondata.hadoop.api.{CarbonInputFormat, CarbonTableInputFormat} | |||
| import org.apache.carbondata.processing.exception.MultipleMatchingException | |||
| import org.apache.carbondata.processing.loading.FailureCauses | |||
| import org.apache.carbondata.spark.DeleteDelataResultImpl | |||
| import org.apache.carbondata.spark.DeleteDelateResultImpl | |||
| @@ -266,9 +266,9 @@ object DeleteExecution { | |||
| CarbonUpdateUtil.getRequiredFieldFromTID(TID, TupleIdEnum.BLOCK_ID) + | |||
| CarbonCommonConstants.FACT_FILE_EXT) | |||
| } | |||
| val deleteDeletaPath = CarbonUpdateUtil | |||
| val deleteDeletePath = CarbonUpdateUtil | |||
There was a problem hiding this comment.
done, change to 'delta'
| @@ -693,10 +693,10 @@ class CarbonSecondaryIndexOptimizer(sparkSession: SparkSession) { | |||
| case sort@Sort(order, global, plan) => | |||
| addProjection = true | |||
| (sort, true) | |||
| case filter@Filter(condition, logicalRelation@MatchIndexableRelation(indexableRelation)) | |||
| case filter@Filter(condition, logicalRelation@MatchIndexTableRelation(indexTableRelation)) | |||
There was a problem hiding this comment.
rename is changing meaning. And actual code is to match CarbonDatasourceHadoopRelation
There was a problem hiding this comment.
Reverted the change.
|
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3552/ |
|
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1812/ |
|
LGTM |
Why is this PR needed?
There are many typos in carbondata-spark module.
What changes were proposed in this PR?
Cleanup code typo in carbondata-spark module
Does this PR introduce any user interface change?
Is any new testcase added?