[CARBONDATA-3960] Default comment should be null when adding columns #3898
Conversation
QiangCai
changed the title
|
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3862/ |
|
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2121/ |
| @@ -693,7 +693,7 @@ class CarbonSpark2SqlParser extends CarbonDDLSqlParser { | |||
| var columnComment: String = "" | |||
| var plainComment: String = "" | |||
| if (col.getComment().isDefined) { | |||
| columnComment = " comment \"" + col.getComment().get + "\"" | |||
| columnComment = " comment '" + col.getComment().get + "'" | |||
There was a problem hiding this comment.
why this change? I didn't get the reason
There was a problem hiding this comment.
Double quotes will lead column comments to be null in some spark versions.
| @@ -624,9 +625,7 @@ class TableNewProcessor(cm: TableModel) { | |||
| if (isVarcharColumn(colName)) { | |||
| columnSchema.setDataType(DataTypes.VARCHAR) | |||
| } | |||
| // TODO: Need to fill RowGroupID, converted type | |||
There was a problem hiding this comment.
is this TODO is completed/not required?
|
retest this please |
|
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2207/ |
|
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3947/ |
|
retest this please |
|
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3955/ |
|
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2215/ |
|
LGTM |
Why is this PR needed?
What changes were proposed in this PR?
Does this PR introduce any user interface change?
Is any new testcase added?