[CARBONDATA-4000] Presto select query failure right after firing update query. #3943
Conversation
| @@ -58,6 +58,17 @@ public void putBoolean(int rowId, boolean value) { | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
please check and handle for ColumnarVectorWrapperDirectWithInvertedIndex, ColumnarVectorWrapperDirectWithDeleteDeltaAndInvertedIndex also
There was a problem hiding this comment.
Done. Issue is with regards to only update query so changes may not be required in ColumnarVectorWrapperDirectWithInvertedIndex.
| public void putObject(int rowId, Object obj) { | ||
| if (!deletedRows.get(rowId)) { | ||
| if (nullBits.get(rowId)) { | ||
| columnVector.putNull(counter++); |
There was a problem hiding this comment.
can you locally test one table with inverted index, I think here should not use counter, may be need to use rowId, convert function is having counter already
There was a problem hiding this comment.
Have raised a separate jira to address this issue - CARBONDATA-4004
|
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2408/ |
|
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4149/ |
|
LGTM. Please create jira for inverted index issue and handle in separate PR |
|
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2440/ |
|
retest this please |
|
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4176/ |
Done |
|
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2442/ |
|
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4185/ |
Why is this PR needed?
The putObject() method implementation was missing due to which select query on struct complex data type after update queries were failing.
What changes were proposed in this PR?
Added implementation in ColumnarVectorWrapperDirectWithDeleteDelta. Earlier without this implementation control went to its parent class AbstractCarbonColumnarVector,java which was unsupported.
Does this PR introduce any user interface change?
Is any new testcase added?