Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-4046] Handled multiple partition columns for partition cache #4002

Closed
wants to merge 1 commit into from

Conversation

nihal0107
Copy link
Contributor

@nihal0107 nihal0107 commented Nov 3, 2020

Why is this PR needed?

Currently when property carbon.read.partition.hive.direct is false then select count * fails on table which contains multiple partition columns.
Handled open points of PR- 3908

  1. Subtraction of the different data types.
  2. If the final cache is empty and the invalid segment list is non-empty then clear the cache.

What changes were proposed in this PR?

Handled multiple partition columns.

  1. Handled subtraction of the different data types.
  2. If the final cache is empty and the invalid segment list is non-empty then clear the cache.

Does this PR introduce any user interface change?

  • No

Is any new testcase added?

  • Yes

@nihal0107 nihal0107 changed the title [WIP]Handled multiple partition columns for partition cache [CARBONDATA-4046]Handled multiple partition columns for partition cache Nov 3, 2020
@CarbonDataQA1
Copy link

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4766/

@CarbonDataQA1
Copy link

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3008/

@QiangCai
Copy link
Contributor

QiangCai commented Nov 5, 2020

please insert a blank into the title, after "]"
"[CARBONDATA-4046] Handled..."

@nihal0107 nihal0107 changed the title [CARBONDATA-4046]Handled multiple partition columns for partition cache [CARBONDATA-4046] Handled multiple partition columns for partition cache Nov 5, 2020
@nihal0107
Copy link
Contributor Author

retest this please.

@CarbonDataQA2
Copy link

retest this please

@CarbonDataQA2
Copy link

test

@CarbonDataQA2
Copy link

test for test

@kunal642
Copy link
Contributor

kunal642 commented Dec 2, 2020

retest this please

@CarbonDataQA2
Copy link

Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3273/

@CarbonDataQA2
Copy link

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5029/

@kunal642
Copy link
Contributor

kunal642 commented Dec 3, 2020

LGTM

@asfgit asfgit closed this in b379ebe Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants