Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-4267][Doc][summer-2021]Update and modify some content in quick-start-guide.md #4197

Closed
wants to merge 2 commits into from

Conversation

ChanceXin
Copy link
Contributor

@ChanceXin ChanceXin commented Aug 5, 2021

Modify minor errors and correct some misunderstandings in the document

Why is this PR needed?

Modify small errors in the document and add some instructions to improve the readability of the document.For example,
1、The local file path of '/local-path/sample.csv' cannot be recognized
2、There some minor errors in the code of 'Option 2: Using SparkSession with CarbonExtensions(since 2.0)'
3、Repeated comments between different parts of the document are added to improve the readability of the document

What changes were proposed in this PR?

Modified some errors in the code and added some necessary instructions

Does this PR introduce any user interface change?

  • No

Is any new testcase added?

  • No

JIRA Issue: https://issues.apache.org/jira/browse/CARBONDATA-4267

Modify minor errors and correct some misunderstandings in the document
@CarbonDataQA2
Copy link

Can one of the admins verify this patch?

@ChanceXin ChanceXin changed the title Update quick-start-guide.md [Doc][summer-2021]Update and modify some content in quick-start-guide.md Aug 5, 2021
@ChanceXin ChanceXin changed the title [Doc][summer-2021]Update and modify some content in quick-start-guide.md [CARBONDATA-4267][Doc][summer-2021]Update and modify some content in quick-start-guide.md Aug 5, 2021
@chenliang613
Copy link
Contributor

add to whitelist

**NOTE**
- In this flow, we can use the built-in SparkSession `spark` instead of `carbon`.
We also can create a new SparkSession instead of the built-in SparkSession `spark` if need.
It need to add "org.apache.spark.sql.CarbonExtensions" into spark configuration "spark.sql.extensions".
```
SparkSession newSpark = SparkSession
val newSpark : SparkSession = SparkSession
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need to change like this ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Option 2, an error will be reported when I use this method to declare a new sparksession object in spark-shell.
image

@CarbonDataQA2
Copy link

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4077/

@CarbonDataQA2
Copy link

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5822/

@CarbonDataQA2
Copy link

Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/225/

@CarbonDataQA2
Copy link

Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5827/

@CarbonDataQA2
Copy link

Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4082/

@CarbonDataQA2
Copy link

Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/230/

@chenliang613
Copy link
Contributor

LGTM

@asfgit asfgit closed this in fac48be Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants