CASSANDRA-19048 - Audit table properties passed through Analytics CqlUtils #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Utils The following properties have an effect on the files generated by the bulk writer, and therefore need to be retained when cleaning the table schema: bloom_filter_fp_chance cdc compression default_time_to_live min_index_interval max_index_interval Additionally, this commit adds tests to make sure all available TTL paths, including table default TTLs and constant/per-row options, work as designed.
frankgh
reviewed
Nov 29, 2023
| String actualCreateStmt = CqlUtils.extractTableSchema(schemaStr, "keyspace", "table"); | ||
| assert expectedCreateStmt.equals(actualCreateStmt); |
There was a problem hiding this comment.
This comment in isolation got me totally confused - thought I literally just removed an assert, and you gave it a 👍 😃
| .withTable(table) | ||
| .withSidecarPort(server.actualPort()) | ||
| .withExtraWriterOptions(Collections.emptyMap()) | ||
| // .withPostWriteDfMods(writeToReadDfFunc(addTTLColumn, addTimestampColumn)) |
| .withTable(table) | ||
| .withSidecarPort(server.actualPort()) | ||
| .withExtraWriterOptions(writerOptions) | ||
| // .withPostWriteDatasetModifier(writeToReadDfFunc(addTTLColumn, addTimestampColumn)) |
|
Committed in c73c764 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following properties have an effect on the files generated by the bulk writer, and therefore need to be retained when cleaning the table schema:
bloom_filter_fp_chance
cdc
compression
default_time_to_live
min_index_interval
max_index_interval
Additionally, this commit adds tests to make sure all available TTL paths, including table default TTLs and constant/per-row options, work as designed.