Skip to content

Commit

Permalink
[CEP-21] Add version guard around call to initializecms
Browse files Browse the repository at this point in the history
  • Loading branch information
Marcus Eriksson authored and beobal committed Nov 24, 2023
1 parent 50f328d commit c0082c9
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions upgrade_tests/upgrade_through_versions_test.py
Expand Up @@ -496,8 +496,10 @@ def upgrade_scenario(self, populate=True, create_schema=True, rolling=False, aft
self._check_values()
self._check_counters()
self._check_select_count()
self.cluster.nodelist()[0].nodetool("initializecms")
# run custom post-upgrade callables

if self.cluster.version() >= '5.1':
self.cluster.nodelist()[0].nodetool("initializecms")

This comment has been minimized.

Copy link
@michaelsembwever

michaelsembwever Nov 26, 2023

Member

curious if in upgrade tests cluster.version() can be >=5.1 but cluster.nodelist()[0] be <5.1

a run of cassandra-5.0 shows there's still a problem here:
 https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/261/workflows/6a15688e-b110-4ede-977c-550b85306867/jobs/21417/tests

# run custom post-upgrade callables
for call in after_upgrade_call:
call()

Expand Down Expand Up @@ -994,4 +996,4 @@ def create_upgrade_class(clsname, version_metas, protocol_version,
[pair.starting_meta, pair.upgrade_meta],
protocol_version=pair.starting_meta.max_proto_v,
bootstrap_test=True
)
)

0 comments on commit c0082c9

Please sign in to comment.