Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASSANDRA-17799 August 2022 blog "Watch the Cassandra World Party" #156

Closed
wants to merge 1 commit into from

Conversation

nonstopdtop
Copy link
Contributor

Chris Thornett, Diogenese Topper; reviewed by -- for CASSANDRA-17799

Co-authored by: Chris Thornett chris@constantia.io
Co-authored by: Diogenese Topper diogenese@constantia.io

Chris Thornett, Diogenese Topper; reviewed by -- for CASSANDRA-17799

Co-authored by: Chris Thornett <chris@constantia.io>
Co-authored by: Diogenese Topper <diogenese@constantia.io>
@michaelsembwever
Copy link
Member

michaelsembwever commented Aug 7, 2022

(low priority)

For the commit message, it needs to be

August 2022 blog "Watch the Cassandra World Party"

 patch by Chris Thornett, Diogenese Topper; reviewed by -- for CASSANDRA-17799

Co-authored by: Chris Thornett <chris@constantia.io>
Co-authored by: Diogenese Topper <diogenese@constantia.io>

Note,

  • first line is a descriptive one liner (no ticket number included),
  • surrounding by blank lines, an optional deeper descriptive paragraph may be written,
  • then the "patch by xxx; reviewed by xxx for CASSANDRA-XXXX" line, which requires that exact format to be parsed by the contribulyze stats
  • finally finished with the optional Co-authored by lines, which allows GitHub to add names to its stats/UI

Copy link
Member

@michaelsembwever michaelsembwever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (have tested it locally)

@michaelsembwever
Copy link
Member

merged manually with 31a3d0b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants