add logging of data directories and multithreaded_compaction

patch by Joaquin Casares; reviewed by jbellis for CASSANDRA-4570
apache · Mar 7, 2013 · 416f80d · 416f80d
1 parent 8daa5d2
commit 416f80d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
@@ -146,8 +146,8 @@ static void loadYaml()
             Yaml yaml = new Yaml(new Loader(constructor));
             conf = (Config)yaml.load(input);
 
-            if (!System.getProperty("os.arch").contains("64"))
-                logger.info("32bit JVM detected.  It is recommended to run Cassandra on a 64bit JVM for better performance.");
+            logger.info("Data files directories: " + Arrays.toString(conf.data_file_directories));
+            logger.info("Commit log directory: " + conf.commitlog_directory);
 
             if (conf.commitlog_sync == null)
             {
@@ -393,7 +393,9 @@ public int compare(InetAddress endpoint1, InetAddress endpoint2)
                 logger.debug("setting auto_bootstrap to " + conf.auto_bootstrap);
             }
 
-           if (conf.in_memory_compaction_limit_in_mb != null && conf.in_memory_compaction_limit_in_mb <= 0)
+            logger.info((conf.multithreaded_compaction ? "" : "Not ") + "using multi-threaded compaction");
+
+            if (conf.in_memory_compaction_limit_in_mb != null && conf.in_memory_compaction_limit_in_mb <= 0)
             {
                 throw new ConfigurationException("in_memory_compaction_limit_in_mb must be a positive integer");
             }

diff --git a/src/java/org/apache/cassandra/service/CassandraDaemon.java b/src/java/org/apache/cassandra/service/CassandraDaemon.java
@@ -119,6 +119,9 @@ public static void initLog4j()
      */
     protected void setup()
     {
+        // log warnings for different kinds of sub-optimal JVMs.  tldr use 64-bit Oracle >= 1.6u32
+        if (!System.getProperty("os.arch").contains("64"))
+            logger.info("32bit JVM detected.  It is recommended to run Cassandra on a 64bit JVM for better performance.");
         String javaVersion = System.getProperty("java.version");
         String javaVmName = System.getProperty("java.vm.name");
         logger.info("JVM vendor/version: {}/{}", javaVmName, javaVersion);