Remove redundant code in StorageProxy#sendToHintedReplicas

patch by Ling Mao; reviewed by Stefan Miklosovic, Brandon Williams and Maxwell Guo for CASSANDRA-19412
apache · Feb 22, 2024 · 8c4a58f · 8c4a58f
1 parent 98d0e18
commit 8c4a58f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -1,4 +1,5 @@
 4.0.13
+ * Remove redundant code in StorageProxy#sendToHintedReplicas (CASSANDRA-19412)
  * Remove bashisms for mx4j tool in cassandra-env.sh (CASSANDRA-19416)
  * Add new concurrent_merkle_tree_requests config property to prevent OOM during multi-range and/or multi-table repairs (CASSANDRA-19336)
 Merged from 3.11:

diff --git a/src/java/org/apache/cassandra/service/StorageProxy.java b/src/java/org/apache/cassandra/service/StorageProxy.java
@@ -1367,8 +1367,6 @@ public static void sendToHintedReplicas(final Mutation mutation,
         Replica localReplica = null;
         Collection<Replica> endpointsToHint = null;
 
-        List<InetAddressAndPort> backPressureHosts = null;
-
         for (Replica destination : plan.contacts())
         {
             checkHintOverload(destination);
@@ -1408,11 +1406,6 @@ public static void sendToHintedReplicas(final Mutation mutation,
 
                         messages.add(destination);
                     }
-
-                    if (backPressureHosts == null)
-                        backPressureHosts = new ArrayList<>(plan.contacts().size());
-
-                    backPressureHosts.add(destination.endpoint());
                 }
             }
             else