Make IncomingTcpConnection responsible for version handling.

Patch by Marcus Erikkson, reviewed by Peter Schuller and brandonwilliams
for CASSANDRA-3166

git-svn-id: https://svn.apache.org/repos/asf/cassandra/branches/cassandra-0.8@1169823 13f79535-47bb-0310-9956-ffa450edef68

src/java/org/apache/cassandra/gms/Gossiper.java

@@ -194,11 +194,13 @@ public void unregister(IEndpointStateChangeSubscriber subscriber)
 
     public void setVersion(InetAddress address, int version)
     {
+        logger.debug("Setting version {} for {}", version, address);
         versions.put(address, version);
     }
 
     public void resetVersion(InetAddress endpoint)
     {
+        logger.debug("Reseting version for {}", endpoint);
         versions.remove(endpoint);
     }
 

src/java/org/apache/cassandra/net/IncomingTcpConnection.java

@@ -158,6 +158,8 @@ public void run()
 
     private void close()
     {
+        // reset version here, since we set when starting an incoming socket
+        Gossiper.instance.resetVersion(socket.getInetAddress());
         try
         {
             socket.close();

src/java/org/apache/cassandra/net/OutboundTcpConnection.java

@@ -139,9 +139,6 @@ private void disconnect()
             output = null;
             socket = null;
         }
-
-        // when we see the node again, try to connect at the most recent protocol we know about
-        Gossiper.instance.resetVersion(endpoint);
     }
 
     private ByteBuffer take()